Easy repro in trunk: 1) https://www.apple.com/apple-events/june-2017/ 2) notifyutil -p org.WebKit.lowMemory.begin
<rdar://problem/32623745>
Created attachment 313874 [details] patch
Comment on attachment 313874 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=313874&action=review > Source/WebCore/platform/graphics/BitmapImage.cpp:229 > + imageObserver()->didDraw(*this); It's confusing, and not very future-proof, to call something called 'didDraw' when we didn't actually draw. > LayoutTests/fast/images/low-memory-decode.html:15 > + }, 100); This will always take 100ms. Consider using shouldBecomeTrue().
> It's confusing, and not very future-proof, to call something called > 'didDraw' when we didn't actually draw. Actually I'll get rid of this for the patch. It is not needed to fix the bug. > > LayoutTests/fast/images/low-memory-decode.html:15 > > + }, 100); > > This will always take 100ms. Consider using shouldBecomeTrue().
Created attachment 313875 [details] patch
> > > LayoutTests/fast/images/low-memory-decode.html:15 > > > + }, 100); > > > > This will always take 100ms. Consider using shouldBecomeTrue(). That doesn't work because it would make the test succeed even without code changes.
Comment on attachment 313875 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=313875&action=review > LayoutTests/fast/images/low-memory-decode.html:15 > + }, 200); Maybe you can bail if you see > 1 decode.
Created attachment 313876 [details] patch
Created attachment 313877 [details] patch
Comment on attachment 313877 [details] patch Attachment 313877 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4003307 New failing tests: fast/images/low-memory-decode.html
Created attachment 313881 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 313877 [details] patch Attachment 313877 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4003402 New failing tests: fast/images/low-memory-decode.html
Created attachment 313884 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 313885 [details] patch
Comment on attachment 313885 [details] patch Clearing flags on attachment: 313885 Committed r218826: <http://trac.webkit.org/changeset/218826>
All reviewed patches have been landed. Closing bug.