Bug 173801 - [GTK+] Homebrew is not allowed to run any script under sudo.
Summary: [GTK+] Homebrew is not allowed to run any script under sudo.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: https://github.com/WebKit/webkit/blob...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-23 18:29 PDT by YuHang
Modified: 2019-08-12 17:53 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.12 KB, patch)
2019-06-10 19:48 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description YuHang 2017-06-23 18:29:10 PDT 
/Tools/gtk/install-dependencies

... line 3
# This script needs to be run with root rights.
if [ $UID -ne 0 ]; then
    sudo $0
    exit 0
fi


These code snippet will cause error while installing dependencies.
Comment 1 overclockedllama 2019-02-02 11:20:28 PST 
fix proposed at https://github.com/WebKit/webkit/pull/30
Comment 2 Alexey Shvayka 2019-06-10 19:48:24 PDT 
Created attachment 371812 [details]
Patch
Comment 3 Alexey Shvayka 2019-06-10 19:52:52 PDT 
Tools/gtk/install-dependencies works fine for me w/o root privileges.
Homebrew 2.1.4
macOS 10.14.4
Comment 4 overclockedllama 2019-06-11 12:00:41 PDT 
Yeah that patch makes more sense. Brew should not run as root.
Comment 5 WebKit Commit Bot 2019-08-12 17:52:55 PDT 
Comment on attachment 371812 [details]
Patch

Clearing flags on attachment: 371812

Committed r248584: <https://trac.webkit.org/changeset/248584>
Comment 6 WebKit Commit Bot 2019-08-12 17:52:57 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-12 17:53:20 PDT 
<rdar://problem/54235619>