Bug 173792 - Add release assertion to make sure callbackIdentifier is not 0 in DocumentLoader::finishedLoadingIcon()
Summary: Add release assertion to make sure callbackIdentifier is not 0 in DocumentLoa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-23 14:56 PDT by Chris Dumez
Modified: 2017-06-23 16:24 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.92 KB, patch)
2017-06-23 14:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-23 14:56:46 PDT 
Add release assertion to make sure callbackIdentifier is not 0 in DocumentLoader::finishedLoadingIcon() as this could cause HashTable corruption on WebPageProxy side.
Comment 1 Chris Dumez 2017-06-23 14:57:58 PDT 
Created attachment 313749 [details]
Patch
Comment 2 Chris Dumez 2017-06-23 14:58:42 PDT 
Comment on attachment 313749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313749&action=review

> Source/WebCore/loader/DocumentLoader.cpp:1698
> +    auto callbackIdentifier = m_iconLoaders.take(&loader);

Renamed because loadIdentifier means something else (see DocumentLoader::didGetLoadDecisionForIcon()).
Comment 3 WebKit Commit Bot 2017-06-23 16:24:15 PDT 
Comment on attachment 313749 [details]
Patch

Clearing flags on attachment: 313749

Committed r218775: <http://trac.webkit.org/changeset/218775>
Comment 4 WebKit Commit Bot 2017-06-23 16:24:16 PDT 
All reviewed patches have been landed.  Closing bug.