Bug 173783 - webrtc::WebRtcSession is not handling correctly its state when setLocalDescription fails and is called again
Summary: webrtc::WebRtcSession is not handling correctly its state when setLocalDescri...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-23 13:08 PDT by youenn fablet
Modified: 2017-06-24 23:13 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.93 KB, patch)
2017-06-23 13:13 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (4.93 KB, patch)
2017-06-23 15:53 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-06-23 13:08:46 PDT 
webrtc::WebRtcSession is not handling correctly its state when setLocalDescription fails and is called again
Comment 1 youenn fablet 2017-06-23 13:09:01 PDT 
rdar://problem/32922986
Comment 2 youenn fablet 2017-06-23 13:12:30 PDT 
See https://bugs.chromium.org/p/chromium/issues/detail?id=677029 for the libwebrtc side
Comment 3 youenn fablet 2017-06-23 13:13:56 PDT 
Created attachment 313737 [details]
Patch
Comment 4 Alex Christensen 2017-06-23 15:04:21 PDT 
Comment on attachment 313737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313737&action=review

> LayoutTests/webrtc/libwebrtc/setLocalDescriptionCrash.html:35
> +    	});

indentation is strange here.
Comment 5 youenn fablet 2017-06-23 15:53:35 PDT 
Created attachment 313755 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-06-23 16:06:51 PDT 
Comment on attachment 313755 [details]
Patch for landing

Clearing flags on attachment: 313755

Committed r218771: <http://trac.webkit.org/changeset/218771>
Comment 7 WebKit Commit Bot 2017-06-23 16:06:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 youenn fablet 2017-06-24 23:13:05 PDT 
setLocalDescriptionCrash.html is timing out in bots.
bug 173817 should handle this issue.