Add support for different versions of iOS when loading test expectations

[Jonathan Bedard]

We should support test expectations for different versions of iOS.

[Radar WebKit Bug Importer]

<rdar://problem/32951132>

[Jonathan Bedard]

Created attachment 313730 [details]
Patch

[Aakash Jain]

Comment on attachment 313730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313730&action=review

rs=me.

> Tools/Scripts/webkitpy/port/ios_device.py:106
> +                if version != device.platform.os_version:

I think "device.platform.os_version != version" would be more readable.

> Tools/Scripts/webkitpy/port/ios_device.py:107
> +                    raise RuntimeError('{} has a version of {} which does not match {}'.format(device, device.platform.os_version, version))

This message might be confusing for readers. Should indicate that there are multiple devices connected having different ios versions.

> Tools/Scripts/webkitpy/port/ios_device.py:109
> +            raise RuntimeError('No devices are available')

Can we move this check about "No devices available" before for loop?

[Jonathan Bedard]

Created attachment 314183 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 314183 [details]
Patch

Clearing flags on attachment: 314183

Committed r218996: <http://trac.webkit.org/changeset/218996>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.