Refactoring the run-gtk-tests script to share the code as much as possible.
Created attachment 313723 [details]
Comment on attachment 313723 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=313723&action=review
> + Move common code from run-gtk-tests to api_test_runner.py, to be shared by both run-gtk-tests and un-wpe-tests.
Committed r225047: <https://trac.webkit.org/changeset/225047>
It broke run-gtk-tests:
Traceback (most recent call last):
File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/run-gtk-tests", line 159, in <module>
if not jhbuildutils.enter_jhbuild_environment_if_available("gtk"):
File "/home/mcatanzaro/Projects/WebKit/Tools/jhbuild/jhbuildutils.py", line 51, in enter_jhbuild_environment_if_available
config = jhbuild.config.Config(get_config_file_for_platform(platform), )
File "/home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesGTK/Source/jhbuild/jhbuild/config.py", line 167, in __init__
File "/home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesGTK/Source/jhbuild/jhbuild/config.py", line 220, in load
_('unknown keys defined in configuration file: %s') % \
NameError: global name '_' is not defined
It has to be imported into Python's builtins namespace using gettext.install(), see https://docs.python.org/2.7/library/gettext.html#gettext.install. jhbuild does that itself, but we break that by trying to call into jhbuild's internal classes directly. So we have to do it ourselves.
I'm confused because none of the code you moved did this, so I'm not sure how it worked before. But whatever.
Committed r225055: <https://trac.webkit.org/changeset/225055>
(In reply to Michael Catanzaro from comment #6)
> Committed r225055: <https://trac.webkit.org/changeset/225055>
Bots are happy again. Well, the API tests are still failing, but they're being run again.