Bug 173762 – [ThreadedCompositor] Update and retrieve scene attributes under a Lock

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[ThreadedCompositor] Update and retrieve scene attributes under a Lock

[Zan Dobersek]

Created attachment 313704 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 313704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313704&action=review

> Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:208
> +    WebCore::IntSize viewportSize;
> +    WebCore::IntPoint scrollPosition;

We don't need the WebCore::

> Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:221
> +    float scaleFactor;
> +    bool drawsBackground;
> +    bool needsResize;
> +    {
> +        LockHolder locker(m_attributes.lock);
> +        viewportSize = m_attributes.viewportSize;
> +        scrollPosition = m_attributes.scrollPosition;
> +        scaleFactor = m_attributes.scaleFactor;
> +        drawsBackground = m_attributes.drawsBackground;
> +        needsResize = m_attributes.needsResize;
> +
> +        // Reset the needsResize attribute to false.
> +        m_attributes.needsResize = false;

Could we simply all this using WTFMove()? Maybe leaving the lock out of the struct and overriding the move in the struct to ensure a reset state after the move.

[Zan Dobersek]

Comment on attachment 313704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313704&action=review

>> Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:221
>> +        m_attributes.needsResize = false;
> 
> Could we simply all this using WTFMove()? Maybe leaving the lock out of the struct and overriding the move in the struct to ensure a reset state after the move.

The data has to be copied. But it could be simplified by gathering all the values in an additional struct. I'll do that in a separate patch.

[Zan Dobersek]

Comment on attachment 313704 [details]
Patch

Clearing flags on attachment: 313704

Committed r219067: <http://trac.webkit.org/changeset/219067>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.