Bug 173753 - ResourceLoadStatisticsStore should be ThreadSafeRefCounted
Summary: ResourceLoadStatisticsStore should be ThreadSafeRefCounted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-22 19:14 PDT by Chris Dumez
Modified: 2017-06-22 19:58 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2017-06-22 19:17 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-22 19:14:57 PDT 
ResourceLoadStatisticsStore should be ThreadSafeRefCounted given code like this:

void ResourceLoadStatisticsStore::fireDataModificationHandler()
{
    ASSERT(!isMainThread());
    RunLoop::main().dispatch([this, protectedThis = makeRef(*this)] () {
        if (m_dataAddedHandler)
            m_dataAddedHandler();
    });
}
Comment 1 Radar WebKit Bug Importer 2017-06-22 19:16:46 PDT 
<rdar://problem/32939326>
Comment 2 Chris Dumez 2017-06-22 19:17:50 PDT 
Created attachment 313685 [details]
Patch
Comment 3 WebKit Commit Bot 2017-06-22 19:58:06 PDT 
Comment on attachment 313685 [details]
Patch

Clearing flags on attachment: 313685

Committed r218734: <http://trac.webkit.org/changeset/218734>
Comment 4 WebKit Commit Bot 2017-06-22 19:58:08 PDT 
All reviewed patches have been landed.  Closing bug.