Web Inspector: Script Timeline bubbles sometimes appear to miss large events

[Joseph Pecoraro]

Summary:
Script Timeline bubbles sometimes appear to miss large events.

In some cases I've seen a Script event, like a Timer Firing, taking "500ms" but not see a bubble in the timeline matching that size.

This makes the script bubbles look suspiciously small, and in the case of Layout + Rendering triggered by script I'd expect to see overlap between the two.

[Joseph Pecoraro]

Created attachment 313672 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 313673 [details]
[IMAGE] Before - Missing Script that triggered Layout

[Joseph Pecoraro]

Created attachment 313674 [details]
[IMAGE] After - Larger Script bubbles including overlap

[BJ Burg]

Comment on attachment 313672 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=313672&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/Timeline.js:74
> +        // Because records can be nested, its posisble that outer records with an early start time

Nit: possible

> Source/WebInspectorUI/UserInterface/Models/Timeline.js:133
> +    _tryInsertInSortedOrder(record)

The name seems funny to me without mentioning 'record' somehow. Maybe Objective-C has corrupted me.

> Source/WebInspectorUI/UserInterface/Models/Timeline.js:144
> +        let end = Math.max(this._records.length - 20, 0);

Likewise, these were terse and I thought they were backwards given the for loop header. Maybe earliestRecordIndex and latestRecordIndex?

[Radar WebKit Bug Importer]

<rdar://problem/32950808>

[Joseph Pecoraro]

<https://trac.webkit.org/r218781>