RESOLVED FIXED 173734
ARM64: doubled executable memory limit from 32MiB to 64MiB
https://bugs.webkit.org/show_bug.cgi?id=173734
Summary ARM64: doubled executable memory limit from 32MiB to 64MiB
JF Bastien
Reported 2017-06-22 14:04:25 PDT
Some WebAssembly programs stress the amount of memory we have available, especially when we consider tiering (BBQ never dies, and is bigger that OMG). Tiering to OMG just piles on more memory, and we're also competing with JavaScript. Separately, I'll try to find places where we allocate too much, and I'll make sure OMG executable allocation failure fails gracefully.
Attachments
patch (1.97 KB, patch)
2017-06-22 14:10 PDT, JF Bastien
no flags
Radar WebKit Bug Importer
Comment 1 2017-06-22 14:05:30 PDT
JF Bastien
Comment 2 2017-06-22 14:10:14 PDT
WebKit Commit Bot
Comment 3 2017-06-22 15:12:29 PDT
Comment on attachment 313659 [details] patch Clearing flags on attachment: 313659 Committed r218723: <http://trac.webkit.org/changeset/218723>
WebKit Commit Bot
Comment 4 2017-06-22 15:12:31 PDT
All reviewed patches have been landed. Closing bug.
Saam Barati
Comment 5 2017-06-22 15:38:45 PDT
Let's also make it so that we throw an OOM instead of crashing when running out of X memory.
JF Bastien
Comment 6 2017-06-22 15:43:55 PDT
(In reply to Saam Barati from comment #5) > Let's also make it so that we throw an OOM instead of crashing when running > out of X memory. Oh right I don’t know why I thought we’d want otherwise! I’ll do that after my investigation.
JF Bastien
Comment 7 2017-06-25 21:59:33 PDT
(In reply to JF Bastien from comment #6) > (In reply to Saam Barati from comment #5) > > Let's also make it so that we throw an OOM instead of crashing when running > > out of X memory. > > Oh right I don’t know why I thought we’d want otherwise! I’ll do that after > my investigation. That's happening here: https://bugs.webkit.org/show_bug.cgi?id=171537
Note You need to log in before you can comment on or make changes to this bug.