Bug 173727 - REGRESSION (r217223): [iOS] Video keeps playing after application is backgrounded
Summary: REGRESSION (r217223): [iOS] Video keeps playing after application is backgrou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-22 10:59 PDT by Jer Noble
Modified: 2017-06-22 11:56 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.61 KB, patch)
2017-06-22 11:00 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-06-22 10:59:13 PDT
REGRESSION (r217223): [iOS] Video keeps playing after application is backgrounded
Comment 1 Jer Noble 2017-06-22 11:00:47 PDT
Created attachment 313641 [details]
Patch
Comment 2 Jer Noble 2017-06-22 11:02:04 PDT
<rdar://problem/32587317>
Comment 3 Eric Carlson 2017-06-22 11:12:47 PDT
Comment on attachment 313641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313641&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5342
> +    m_elementIsHidden = document().hidden() && m_videoFullscreenMode != VideoFullscreenModePictureInPicture;

Don't we also want to override when playing to AppleTV?
Comment 4 Jer Noble 2017-06-22 11:40:22 PDT
(In reply to Eric Carlson from comment #3)
> Comment on attachment 313641 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313641&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:5342
> > +    m_elementIsHidden = document().hidden() && m_videoFullscreenMode != VideoFullscreenModePictureInPicture;
> 
> Don't we also want to override when playing to AppleTV?

That's handled in shouldOverrideBackgroundPlaybackRestriction(); in the case that we are playing to the AppleTV, the interruption is overridden.
Comment 5 WebKit Commit Bot 2017-06-22 11:56:19 PDT
Comment on attachment 313641 [details]
Patch

Clearing flags on attachment: 313641

Committed r218710: <http://trac.webkit.org/changeset/218710>
Comment 6 WebKit Commit Bot 2017-06-22 11:56:20 PDT
All reviewed patches have been landed.  Closing bug.