Bug 173727 – REGRESSION (r217223): [iOS] Video keeps playing after application is backgrounded

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

REGRESSION (r217223): [iOS] Video keeps playing after application is backgrounded

[Jer Noble]

Created attachment 313641 [details]
Patch

[Jer Noble]

<rdar://problem/32587317>

[Eric Carlson]

Comment on attachment 313641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313641&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5342
> +    m_elementIsHidden = document().hidden() && m_videoFullscreenMode != VideoFullscreenModePictureInPicture;

Don't we also want to override when playing to AppleTV?

[Jer Noble]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 313641 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313641&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:5342
> > +    m_elementIsHidden = document().hidden() && m_videoFullscreenMode != VideoFullscreenModePictureInPicture;
> 
> Don't we also want to override when playing to AppleTV?

That's handled in shouldOverrideBackgroundPlaybackRestriction(); in the case that we are playing to the AppleTV, the interruption is overridden.

[WebKit Commit Bot]

Comment on attachment 313641 [details]
Patch

Clearing flags on attachment: 313641

Committed r218710: <http://trac.webkit.org/changeset/218710>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.