Bug 173725 - REGRESSION: LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky timeout on Sierra
Summary: REGRESSION: LayoutTest media/modern-media-controls/placard-support/placard-su...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-22 10:41 PDT by Ryan Haddad
Modified: 2018-03-21 10:50 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.64 KB, patch)
2017-06-22 11:34 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Ryan Haddad 2017-06-22 10:42:40 PDT
This started yesterday, but I haven't identified the commit that caused it.

Antoine, can you take a look at this? It is currently timing out more often than it passes.
Comment 2 Antoine Quint 2017-06-22 11:22:42 PDT
The test enters fullscreen on WK1 rather than picture-in-picture, at least on High Sierra. It looks like something changed in WebCore.
Comment 3 Antoine Quint 2017-06-22 11:34:54 PDT
Created attachment 313645 [details]
Patch
Comment 4 Antoine Quint 2017-06-22 11:35:11 PDT
See https://bugs.webkit.org/show_bug.cgi?id=173729 for the fullscreen vs. PiP issue.
Comment 5 WebKit Commit Bot 2017-06-22 15:47:03 PDT
Comment on attachment 313645 [details]
Patch

Clearing flags on attachment: 313645

Committed r218725: <http://trac.webkit.org/changeset/218725>
Comment 6 WebKit Commit Bot 2017-06-22 15:47:04 PDT
All reviewed patches have been landed.  Closing bug.