Bug 173717 - Fix memory leak in LibWebRTCMediaEndpoint
Summary: Fix memory leak in LibWebRTCMediaEndpoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-22 09:05 PDT by youenn fablet
Modified: 2017-06-22 12:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.43 KB, patch)
2017-06-22 09:07 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (2.02 MB, application/zip)
2017-06-22 11:51 PDT, Build Bot 		no flags Details
Fixing mock (4.43 KB, patch)
2017-06-22 12:13 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-06-22 09:05:35 PDT 
LibWebRTC is passing offer/answer structure ownership to WebCore.
Comment 1 youenn fablet 2017-06-22 09:07:00 PDT 
Created attachment 313634 [details]
Patch
Comment 2 youenn fablet 2017-06-22 09:08:09 PDT 
rdar://problem/32546186
Comment 3 Build Bot 2017-06-22 11:51:11 PDT 
Comment on attachment 313634 [details]
Patch

Attachment 313634 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3979040

New failing tests:
fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html
fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html
fast/mediastream/RTCPeerConnection-inspect-offer.html
fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html
fast/mediastream/RTCPeerConnection-inspect-answer.html
fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html
fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html
fast/mediastream/RTCPeerConnection-icecandidate-event.html
webrtc/libwebrtc/release-while-setting-local-description.html
fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html
Comment 4 Build Bot 2017-06-22 11:51:13 PDT 
Created attachment 313647 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 5 youenn fablet 2017-06-22 12:13:35 PDT 
Created attachment 313648 [details]
Fixing mock
Comment 6 WebKit Commit Bot 2017-06-22 12:54:09 PDT 
Comment on attachment 313648 [details]
Fixing mock

Clearing flags on attachment: 313648

Committed r218714: <http://trac.webkit.org/changeset/218714>
Comment 7 WebKit Commit Bot 2017-06-22 12:54:11 PDT 
All reviewed patches have been landed.  Closing bug.