Bug 173712 – [WPE] User script messages don't work

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Carlos Garcia Campos]

The main reason why it doesn't work is because it's disabled in the build, but even enabling them, we don't have a way in WPE to get the js global context from the WebScriptMessageHandler client.

[Carlos Garcia Campos]

TEST: bin/TestWebKitAPI/WPE/TestWebKitUserContentManager... (pid=22808)
  /wpe/WebKitWebView/new-with-user-content-manager:                    OK
  /wpe/WebKitUserContentManager/injected-style-sheet:                  Error sending IPC message: Connection reset by peer
OK
  /wpe/WebKitUserContentManager/injected-script:                       Error sending IPC message: Connection reset by peer
OK
  /wpe/WebKitUserContentManager/script-message-received:               **
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:270:void testUserContentManagerScriptMessageReceived(UserScriptMessageTest*, gconstpointer): assertion failed: (javascriptResult)
FAIL
GTester: last random seed: R02S2dfde0838a0fd6b1ed62f08b98a8a639
(pid=22917)
FAIL: bin/TestWebKitAPI/WPE/TestWebKitUserContentManager

[Carlos Garcia Campos]

Created attachment 313613 [details]
Patch

[Sam Weinig]

Comment on attachment 313613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313613&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:641
> +#if PLATFORM(WPE)
> +    WKWPE::View& view();
> +#endif

Please don't add view accessors to WebPageProxy, we have been working to remove the ones in the cocoa platform.  Instead please add PageClient functions for the functionality you need.

[Carlos Garcia Campos]

(In reply to Sam Weinig from comment #3)
> Comment on attachment 313613 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313613&action=review
> 
> > Source/WebKit2/UIProcess/WebPageProxy.h:641
> > +#if PLATFORM(WPE)
> > +    WKWPE::View& view();
> > +#endif
> 
> Please don't add view accessors to WebPageProxy, we have been working to
> remove the ones in the cocoa platform.  Instead please add PageClient
> functions for the functionality you need.

Sure, I didn't know that

[Carlos Garcia Campos]

Created attachment 313628 [details]
Patch

[Carlos Garcia Campos]

Committed r218740: <http://trac.webkit.org/changeset/218740>