Bug 173707 - [WPE] Page should be closed on WebKitWebView dispose
Summary: [WPE] Page should be closed on WebKitWebView dispose
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-22 02:58 PDT by Carlos Garcia Campos
Modified: 2017-06-22 04:17 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.38 KB, patch)
2017-06-22 03:01 PDT, Carlos Garcia Campos
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-06-22 02:58:01 PDT
In the GTK+ port it's done in the WebKitWebViewBase dispose implementation. It causes an assertion in web process when running TestMultiprocess

TEST: bin/TestWebKitAPI/WPE/TestMultiprocess... (pid=21466)
  /wpe/WebKitWebContext/process-per-web-view:                          OK
  /wpe/WebKitWebContext/web-process-limit:                             Error sending IPC message: Broken pipe
Error sending IPC message: Broken pipe
OK
  /wpe/WebKitWebView/multiprocess-create-ready-close:                  OK
**
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:131:void emitURIChanged(GDBusConnection*, const char*): assertion failed: (ok)
Comment 1 Carlos Garcia Campos 2017-06-22 03:01:44 PDT
Created attachment 313605 [details]
Patch
Comment 2 Build Bot 2017-06-22 03:03:49 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2017-06-22 04:17:05 PDT
Committed r218688: <http://trac.webkit.org/changeset/218688>