Bug 173702 - [WPE] Build glib API tests
Summary: [WPE] Build glib API tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 173705
Blocks:
  Show dependency tree / graph
 
Reported: 2017-06-22 02:05 PDT by Carlos Garcia Campos
Modified: 2017-06-22 04:12 PDT (History)
2 users (show)

See Also:

Attachments
Patch (91.57 KB, patch)
2017-06-22 02:17 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (92.37 KB, patch)
2017-06-22 02:28 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (93.10 KB, patch)
2017-06-22 03:05 PDT, Carlos Garcia Campos 		zan: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-06-22 02:05:33 PDT 
Many of the tests pass without problems, others need to be investigated, and some others are known issues.
Comment 1 Carlos Garcia Campos 2017-06-22 02:17:06 PDT 
Created attachment 313600 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-06-22 02:28:11 PDT 
Created attachment 313601 [details]
Patch

I forgot to git add the wpe makefile.
Comment 3 Carlos Garcia Campos 2017-06-22 03:05:02 PDT 
Created attachment 313606 [details]
Patch
Comment 4 Zan Dobersek 2017-06-22 03:15:42 PDT 
Comment on attachment 313606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313606&action=review

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:57
> +#if PLATFORM(GTK)
>              memset(&m_geometry, 0, sizeof(GdkRectangle));
> +#endif

sizeof(GdkRectangle) is wrong, should be cairo_rectangle_int_t.

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:97
> +#if PLATFORM(GTK)
>              g_assert_cmpint(m_geometry.x, ==, other.m_geometry.x);
>              g_assert_cmpint(m_geometry.y, ==, other.m_geometry.y);
>              g_assert_cmpint(m_geometry.width, ==, other.m_geometry.width);
>              g_assert_cmpint(m_geometry.height, ==, other.m_geometry.height);
> +#endif

Can't this work for WPE as well with m_geometry being cairo_rectangle_int_t? Or is webkit_window_properties_get_geometry() not implemented for WPE?
Comment 5 Carlos Garcia Campos 2017-06-22 03:20:18 PDT 
(In reply to Zan Dobersek from comment #4)
> Comment on attachment 313606 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313606&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:57
> > +#if PLATFORM(GTK)
> >              memset(&m_geometry, 0, sizeof(GdkRectangle));
> > +#endif
> 
> sizeof(GdkRectangle) is wrong, should be cairo_rectangle_int_t.

There's no geometry in WPE yet, we need to figure out how to expose it. I used cairo rectangle in the other cases to reduce the amount of ifdefs, but it's not expected to work until we expose rectangle in WPE API.

> > Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:97
> > +#if PLATFORM(GTK)
> >              g_assert_cmpint(m_geometry.x, ==, other.m_geometry.x);
> >              g_assert_cmpint(m_geometry.y, ==, other.m_geometry.y);
> >              g_assert_cmpint(m_geometry.width, ==, other.m_geometry.width);
> >              g_assert_cmpint(m_geometry.height, ==, other.m_geometry.height);
> > +#endif
> 
> Can't this work for WPE as well with m_geometry being cairo_rectangle_int_t?
> Or is webkit_window_properties_get_geometry() not implemented for WPE?

Exactly.
Comment 6 Carlos Garcia Campos 2017-06-22 04:12:51 PDT 
Committed r218686: <http://trac.webkit.org/changeset/218686>