Bug 173702 – [WPE] Build glib API tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Carlos Garcia Campos]

Many of the tests pass without problems, others need to be investigated, and some others are known issues.

[Carlos Garcia Campos]

Created attachment 313600 [details]
Patch

[Carlos Garcia Campos]

Created attachment 313601 [details]
Patch

I forgot to git add the wpe makefile.

[Carlos Garcia Campos]

Created attachment 313606 [details]
Patch

[Zan Dobersek]

Comment on attachment 313606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313606&action=review

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:57
> +#if PLATFORM(GTK)
>              memset(&m_geometry, 0, sizeof(GdkRectangle));
> +#endif

sizeof(GdkRectangle) is wrong, should be cairo_rectangle_int_t.

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:97
> +#if PLATFORM(GTK)
>              g_assert_cmpint(m_geometry.x, ==, other.m_geometry.x);
>              g_assert_cmpint(m_geometry.y, ==, other.m_geometry.y);
>              g_assert_cmpint(m_geometry.width, ==, other.m_geometry.width);
>              g_assert_cmpint(m_geometry.height, ==, other.m_geometry.height);
> +#endif

Can't this work for WPE as well with m_geometry being cairo_rectangle_int_t? Or is webkit_window_properties_get_geometry() not implemented for WPE?

[Carlos Garcia Campos]

(In reply to Zan Dobersek from comment #4)
> Comment on attachment 313606 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313606&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:57
> > +#if PLATFORM(GTK)
> >              memset(&m_geometry, 0, sizeof(GdkRectangle));
> > +#endif
> 
> sizeof(GdkRectangle) is wrong, should be cairo_rectangle_int_t.

There's no geometry in WPE yet, we need to figure out how to expose it. I used cairo rectangle in the other cases to reduce the amount of ifdefs, but it's not expected to work until we expose rectangle in WPE API.

> > Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:97
> > +#if PLATFORM(GTK)
> >              g_assert_cmpint(m_geometry.x, ==, other.m_geometry.x);
> >              g_assert_cmpint(m_geometry.y, ==, other.m_geometry.y);
> >              g_assert_cmpint(m_geometry.width, ==, other.m_geometry.width);
> >              g_assert_cmpint(m_geometry.height, ==, other.m_geometry.height);
> > +#endif
> 
> Can't this work for WPE as well with m_geometry being cairo_rectangle_int_t?
> Or is webkit_window_properties_get_geometry() not implemented for WPE?

Exactly.

[Carlos Garcia Campos]

Committed r218686: <http://trac.webkit.org/changeset/218686>