Bug 173693 - Add some thread safety guards to GenericCallback
Summary: Add some thread safety guards to GenericCallback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-21 22:35 PDT by Brady Eidson
Modified: 2017-06-22 10:42 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.25 KB, patch)
2017-06-21 22:38 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-06-21 22:35:51 PDT 
Add some thread safety guards to GenericCallback

A callback should be created, performed, invalidated, and/or destroyed all on the same thread.

Let's write code to notify us if that doesn't happen.
Comment 1 Brady Eidson 2017-06-21 22:38:46 PDT 
Created attachment 313585 [details]
Patch
Comment 2 Brady Eidson 2017-06-21 22:39:22 PDT 
(I haven't even compiled yet, justing throwing this at EWS for now)
Comment 3 WebKit Commit Bot 2017-06-22 10:34:39 PDT 
Comment on attachment 313585 [details]
Patch

Clearing flags on attachment: 313585

Committed r218705: <http://trac.webkit.org/changeset/218705>
Comment 4 WebKit Commit Bot 2017-06-22 10:34:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 mitz 2017-06-22 10:42:10 PDT 
Comment on attachment 313585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313585&action=review

> Source/WebKit2/UIProcess/GenericCallback.h:153
> +#ifndef NDEBUG

This should be #if !ASSERT_DISABLED instead.