RESOLVED FIXED 173691
pretty patch doesn't show image diffs with newer versions of git 
https://bugs.webkit.org/show_bug.cgi?id=173691
Summary pretty patch doesn't show image diffs with newer versions of git
Carlos Alberto Lopez Perez
Reported 2017-06-21 20:17:06 PDT
Tools/Scripts/webkit-patch pretty-diff or Tools/Scripts/show-pretty-diff doesn't generate images anymore with newer versions of git. Instead of the image an error appears saying: Error running git apply --directory=/tmp with patch: diff --git a/PrettyPatch20170622-32032-41lcvr.bin b/PrettyPatch20170622-32032-41lcvr.bin new file mode 100644 index 0000000000000000000000000000000000000000..e03210de3ed0f0bfe3ca9a4fe73386d7ed93fb73 GIT binary patch literal 3278 zcmeAS@N?(olHy`uVBq!ia0y~yU{+vYV2a>i0*Z)=h^hlA%@Ws$lH`ok<m}?oTn5WT zBLhn_Ln9Ll!?eWYM58nV6B9Ed^Q1H*1H)8{By)$IF1LZ2*pj^6T^Rm@;DWu&Co?ec z_<6cGhE&XXd-q`O?Fa_fiw_-mmnd!IxNeZ^vQqhMz}Y3e_OB%t9+ZrK>HWzvTIxu2 zT+O6wM#p||Gc@r3{qgbf5BdMKyJZ;|;wK+qV(8%1VQ83v!MKt6{?I0!?{^p(K5$H` z7kt... error: invalid path '/tmp/PrettyPatch20170622-32032-41lcvr.bin' This "error: invalid path" is caused because git >= 2.3.3 added an extra security check enabled by default that forbids git apply to work on files outside of the working area. To return back to the previous behaviour the argument --unsafe-paths can be passed.
Attachments
Patch (2.00 KB, patch)
2017-06-21 20:25 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2017-06-21 20:25:24 PDT
Created attachment 313580 [details] Patch
WebKit Commit Bot
Comment 2 2017-06-22 12:38:42 PDT
Comment on attachment 313580 [details] Patch Clearing flags on attachment: 313580 Committed r218711: <http://trac.webkit.org/changeset/218711>
WebKit Commit Bot
Comment 3 2017-06-22 12:38:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.