Bug 173680 - Add release assertions help diagnose a hang in CallbackMap
Summary: Add release assertions help diagnose a hang in CallbackMap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-21 16:33 PDT by Ryosuke Niwa
Modified: 2017-06-22 16:52 PDT (History)
5 users (show)

See Also:


Attachments
Adds assertion (1.91 KB, patch)
2017-06-21 16:37 PDT, Ryosuke Niwa
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-06-21 16:33:18 PDT
We're seeing a hang inside WebKit::CallbackMap in Safari,
and we suspect it could be caused by a hash table corruption.

Add release assertions to make sure this hash table isn't used in a non-main thread and empty value isn't used as a key.
Comment 1 Radar WebKit Bug Importer 2017-06-21 16:34:59 PDT
<rdar://problem/32911286>
Comment 2 Ryosuke Niwa 2017-06-21 16:37:09 PDT
Created attachment 313564 [details]
Adds assertion
Comment 3 Ryosuke Niwa 2017-06-21 19:44:14 PDT
Committed r218676: <http://trac.webkit.org/changeset/218676>