Bug 173678 – [WebCrypto] Restore ordering of CryptoAlgorithmIdentifier in SerializedScriptValue

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jiewen Tan]

r218030 reorders the ordering of CryptoAlgorithmIdentifier in SerializedScriptValue, which introduce backward compatibility issue with CryptoKey objects stored in the IndexedDB. Hence, we should restore it back.

[Jiewen Tan]

<rdar://problem/32879314>

[Jiewen Tan]

Created attachment 313561 [details]
Patch

[Jiewen Tan]

Here is r218030 for reference.
https://trac.webkit.org/changeset/218030/webkit

[Build Bot]

Attachment 313561 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:245:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:246:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:247:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:248:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:249:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:250:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:251:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:252:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:253:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:254:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:255:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 11 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 313561 [details]
Patch

Seems like we should have some tests that read from pre-baked IndexedDB databases (e.g. checkin the database to the tests repository, and teach WKTR and DRT to be able to use that database for a particular test).

[Jiewen Tan]

(In reply to Sam Weinig from comment #5)
> Comment on attachment 313561 [details]
> Patch
> 
> Seems like we should have some tests that read from pre-baked IndexedDB
> databases (e.g. checkin the database to the tests repository, and teach WKTR
> and DRT to be able to use that database for a particular test).

Agreed. Glad to help to make this happen.

[Jiewen Tan]

Comment on attachment 313561 [details]
Patch

Thanks Sam for r+ my patch.

[WebKit Commit Bot]

Comment on attachment 313561 [details]
Patch

Clearing flags on attachment: 313561

Committed r218666: <http://trac.webkit.org/changeset/218666>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jon Lee]

*** Bug 174141 has been marked as a duplicate of this bug. ***