Sorted Patch Queue Names in Alphabetical Order
Created attachment 315720 [details] Sorted the EWS on the Patch Page
Created attachment 315850 [details] Added Individual EWS status pages and kept the Original EWS Page. I also added a page if its been waiting in Queue and processing hasn't started.
Created attachment 315858 [details] Linked the statusbubble page with the individual ews page.
Comment on attachment 315720 [details] Sorted the EWS on the Patch Page Please clean up the patch and the ChangeLog.
Comment on attachment 315850 [details] Added Individual EWS status pages and kept the Original EWS Page. This patch does a lot of things which are totally unrelated to sorting the status messages. Please have the clean patch doing only what the bug is about. Also when you upload a new patch, please mark this patch as obsolete. Also, you should not include your local changes you use for debugging in the patch (e.g.: common/net/bugzilla/bugzilla.py).
Comment on attachment 315858 [details] Linked the statusbubble page with the individual ews page. Same comments as above. Please have a clean patch. This patch seems to have a lot of unrelated changes and lot of debugging statements.
Created attachment 316981 [details] Sorted the EWS on the Patch Page
Comment on attachment 316981 [details] Sorted the EWS on the Patch Page View in context: https://bugs.webkit.org/attachment.cgi?id=316981&action=review > Tools/ChangeLog:3 > + Unsorted EWS on patch page Unsorted? > Tools/ChangeLog:7 > + Please add the description of changes in ChangeLog. Please see https://webkit.org/contributing-code/#changelog-files
*** Bug 175043 has been marked as a duplicate of this bug. ***
Comment on attachment 316981 [details] Sorted the EWS on the Patch Page >Index: Tools/ChangeLog >=================================================================== >--- Tools/ChangeLog (revision 220109) >+++ Tools/ChangeLog (working copy) >@@ -1,3 +1,14 @@ >+2017-08-01 obinna obike <oobike@apple.com> >+ >+ Sorted EWS on patch page >+ https://bugs.webkit.org/show_bug.cgi?id=175043 >+ >+ Reviewed by NOBODY (OOPS!). Sorted the EWS in alphabetical order on the patch page to make it easier for engineers to find specific EWS. >+ >+ * QueueStatusServer/handlers/patch.py: >+ (Patch.get): >+ * QueueStatusServer/templates/patch.html: >+ > 2017-07-26 Jiewen Tan <jiewen_tan@apple.com> > > Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future >Index: Tools/QueueStatusServer/handlers/patch.py >=================================================================== >--- Tools/QueueStatusServer/handlers/patch.py (revision 219533) >+++ Tools/QueueStatusServer/handlers/patch.py (working copy) >@@ -44,7 +44,7 @@ class Patch(webapp.RequestHandler): > per_queue_statuses = queue_status.get(status.queue_name, []) > per_queue_statuses.append(status) > queue_status[status.queue_name] = per_queue_statuses >- >+ queue_status = sorted(queue_status.items()) > template_values = { > "attachment_id" : attachment_id, > "bug_id" : bug_id, >Index: Tools/QueueStatusServer/templates/patch.html >=================================================================== >--- Tools/QueueStatusServer/templates/patch.html (revision 219533) >+++ Tools/QueueStatusServer/templates/patch.html (working copy) >@@ -7,7 +7,7 @@ > <body> > <h1> > Patch {{ attachment_id|force_escape|webkit_attachment_id|safe }} (Bug {{ bug_id|force_escape|webkit_bug_id|safe }}) >-</h1>{% for queue_name, statuses in queue_status.items %} >+</h1>{% for queue_name, statuses in queue_status %} > <div class="status-details"> > <h2>{{ queue_name }}</h2> > <ul>{% for status in statuses %}
Comment on attachment 316981 [details] Sorted the EWS on the Patch Page >Index: Tools/ChangeLog >=================================================================== >--- Tools/ChangeLog (revision 220109) >+++ Tools/ChangeLog (working copy) >@@ -1,3 +1,14 @@ >+2017-08-01 obinna obike <oobike@apple.com> >+ >+ Sorted EWS on patch page >+ https://bugs.webkit.org/show_bug.cgi?id=175043 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * QueueStatusServer/handlers/patch.py: >+ (Patch.get): set queue_status as sorted of queue_status.items() >+ * QueueStatusServer/templates/patch.html: changes queue_status.items to queue_status >+ > 2017-07-26 Jiewen Tan <jiewen_tan@apple.com> > > Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future >Index: Tools/QueueStatusServer/handlers/patch.py >=================================================================== >--- Tools/QueueStatusServer/handlers/patch.py (revision 219533) >+++ Tools/QueueStatusServer/handlers/patch.py (working copy) >@@ -44,7 +44,7 @@ class Patch(webapp.RequestHandler): > per_queue_statuses = queue_status.get(status.queue_name, []) > per_queue_statuses.append(status) > queue_status[status.queue_name] = per_queue_statuses >- >+ queue_status = sorted(queue_status.items()) > template_values = { > "attachment_id" : attachment_id, > "bug_id" : bug_id, >Index: Tools/QueueStatusServer/templates/patch.html >=================================================================== >--- Tools/QueueStatusServer/templates/patch.html (revision 219533) >+++ Tools/QueueStatusServer/templates/patch.html (working copy) >@@ -7,7 +7,7 @@ > <body> > <h1> > Patch {{ attachment_id|force_escape|webkit_attachment_id|safe }} (Bug {{ bug_id|force_escape|webkit_bug_id|safe }}) >-</h1>{% for queue_name, statuses in queue_status.items %} >+</h1>{% for queue_name, statuses in queue_status %} > <div class="status-details"> > <h2>{{ queue_name }}</h2> > <ul>{% for status in statuses %}
Did u tried to upload a patch? Seems like something went wrong.
Created attachment 317441 [details] Sorted the EWS on the Patch Page
Created attachment 317458 [details] Sort the EWS Queues on Patch Page
Patch looks good, but every line is ending with '\'. Please re-upload.
Created attachment 317488 [details] updated patch
Created attachment 317489 [details] Updated patch
Comment on attachment 317489 [details] Updated patch Clearing flags on attachment: 317489 Committed r220369: <http://trac.webkit.org/changeset/220369>
All reviewed patches have been landed. Closing bug.
<rdar://problem/33765016>
Updated the server. This changes is now live.