Bug 173663 - B3BreakCriticalEdges.cpp with /O2 causes ICE in VS2015, 2017
Summary: B3BreakCriticalEdges.cpp with /O2 causes ICE in VS2015, 2017
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-21 11:05 PDT by Vladimir Vukicevic
Modified: 2017-06-22 08:53 PDT (History)
0 users

See Also:

Attachments
make this file build with /Os (1.03 KB, patch)
2017-06-22 08:53 PDT, Vladimir Vukicevic 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Vukicevic 2017-06-21 11:05:15 PDT 
With Visual Studio 2015, 2017 (vc 14.0/14.1) building B3BreakCriticalEdges.cpp with the default /O2 (or /Ox) causes an internal compiler error:

c:\proj\js\webkit\source\javascriptcore\b3\b3breakcriticaledges.cpp(62) : fatal error C1001: An internal error has occurred in the compiler.
(compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 255)
 To work around this problem, try simplifying or changing the program near the locations listed above.
Please choose the Technical Support command on the Visual C++
 Help menu, or open the Technical Support help file for more information

INTERNAL COMPILER ERROR in 'C:\PROGRA~2\MICROS~1\2017\PROFES~1\VC\Tools\MSVC\1410~1.250\bin\HostX86\x64\cl.exe'
    Please choose the Technical Support command on the Visual C++
    Help menu, or open the Technical Support help file for more information

"/Os" builds fine.
Comment 1 Vladimir Vukicevic 2017-06-22 08:53:35 PDT 
Created attachment 313630 [details]
make this file build with /Os

This fixes it for me, though it does rely on cmake always appending source options.  I think that's safe, though.