Bug 173659 - [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
Summary: [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subse...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-21 09:56 PDT by Wenson Hsieh
Modified: 2017-06-21 19:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.99 KB, patch)
2017-06-21 11:03 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (9.20 KB, patch)
2017-06-21 16:02 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-06-21 09:56:17 PDT 
<rdar://problem/32879788>
Comment 1 Wenson Hsieh 2017-06-21 11:03:21 PDT 
Created attachment 313533 [details]
Patch
Comment 2 Tim Horton 2017-06-21 13:58:33 PDT 
Comment on attachment 313533 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313533&action=review

> Source/WebKit2/ChangeLog:14
> +        calling into -dragInteracton:itemsForBeginningSession: when we invoke their completion block).

dragInteracton!
Comment 3 Wenson Hsieh 2017-06-21 13:59:38 PDT 
(In reply to Tim Horton from comment #2)
> Comment on attachment 313533 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313533&action=review
> 
> > Source/WebKit2/ChangeLog:14
> > +        calling into -dragInteracton:itemsForBeginningSession: when we invoke their completion block).
> 
> dragInteracton!

Good catch! Fixed.
Comment 4 Wenson Hsieh 2017-06-21 16:02:20 PDT 
Created attachment 313558 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-06-21 18:41:40 PDT 
Comment on attachment 313558 [details]
Patch for landing

Clearing flags on attachment: 313558

Committed r218672: <http://trac.webkit.org/changeset/218672>