Bug 173656 - Remove expat source code from Source/ThirdParty/libwebrtc
Summary: Remove expat source code from Source/ThirdParty/libwebrtc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on: 173665
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-21 09:26 PDT by youenn fablet
Modified: 2017-06-27 09:20 PDT (History)
6 users (show)

See Also:


Attachments
Patch (697.96 KB, patch)
2017-06-21 09:27 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-06-21 09:26:41 PDT
They are not used anymore
Comment 1 youenn fablet 2017-06-21 09:27:42 PDT
Created attachment 313523 [details]
Patch
Comment 2 Build Bot 2017-06-21 09:30:17 PDT
Attachment 313523 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/ChangeLog:42:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzer  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brent Fulgham 2017-06-21 09:31:59 PDT
r=me (as long as the bots are happy!)
Comment 4 WebKit Commit Bot 2017-06-21 13:52:27 PDT
Comment on attachment 313523 [details]
Patch

Clearing flags on attachment: 313523

Committed r218646: <http://trac.webkit.org/changeset/218646>
Comment 5 WebKit Commit Bot 2017-06-21 13:52:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2017-06-21 13:59:38 PDT
Re-opened since this is blocked by bug 173665