Bug 173649 - Import W3C tests regarding navigation inside sandboxed iframes
Summary: Import W3C tests regarding navigation inside sandboxed iframes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on: 173651
Blocks: 173162 173657
  Show dependency tree / graph
 
Reported: 2017-06-21 06:44 PDT by Frédéric Wang (:fredw)
Modified: 2017-06-21 10:08 PDT (History)
3 users (show)

See Also:

Attachments
Patch (36.96 KB, patch)
2017-06-21 09:21 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2017-06-21 06:44:58 PDT 
https://github.com/w3c/web-platform-tests/pull/6221
Comment 1 Frédéric Wang (:fredw) 2017-06-21 08:07:05 PDT 
Hi Youen. I'm trying to update the tests in web-platform-tests/html/semantics/embedded-content/the-iframe-element but import-w3c-tests is now returning weird Python errors. I did not get them when I tried to do that import in bug 173162. Are you aware of any recent changes that could have cause this issue?
Comment 2 Frédéric Wang (:fredw) 2017-06-21 09:21:12 PDT 
Created attachment 313522 [details]
Patch
Comment 3 youenn fablet 2017-06-21 09:25:34 PDT 
Comment on attachment 313522 [details]
Patch

rs=me.
Some of these tests are timing out.
Are you planning to fix them in the short term?
If not, maybe they could be skipped?
Comment 4 Frédéric Wang (:fredw) 2017-06-21 09:58:24 PDT 
(In reply to youenn fablet from comment #3)
> Comment on attachment 313522 [details]
> Patch
> 
> rs=me.
> Some of these tests are timing out.
> Are you planning to fix them in the short term?
> If not, maybe they could be skipped?

It seems to be a bug in WebKit (they don't happen on Chromium and Gecko). However, my goal is to check that the navigation is indeed forbidden in these cases so for now I'm happy to keep the text reference. I've moved this to bug 173657
Comment 5 WebKit Commit Bot 2017-06-21 10:08:06 PDT 
Comment on attachment 313522 [details]
Patch

Clearing flags on attachment: 313522

Committed r218639: <http://trac.webkit.org/changeset/218639>
Comment 6 WebKit Commit Bot 2017-06-21 10:08:07 PDT 
All reviewed patches have been landed.  Closing bug.