RESOLVED FIXED 173642
[GTK] Move WebKit2 GLib API tests to glib directories 
https://bugs.webkit.org/show_bug.cgi?id=173642
Summary [GTK] Move WebKit2 GLib API tests to glib directories
Carlos Garcia Campos
Reported 2017-06-21 03:23:38 PDT
So that they could be shared by WPE GLib API.
Attachments
Patch (46.74 KB, patch)
2017-06-21 03:27 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (45.98 KB, patch)
2017-06-21 05:56 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (45.14 KB, patch)
2017-06-22 00:11 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
Patch for landing (45.14 KB, patch)
2017-06-22 00:38 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-06-21 03:27:23 PDT
Created attachment 313503 [details] Patch
Build Bot
Comment 2 2017-06-21 03:31:30 PDT
Attachment 313503 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:841: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 50 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 3 2017-06-21 05:56:07 PDT
Created attachment 313508 [details] Patch Keep TestEditor as GTK+ only since it uses DOM API for everything.
Build Bot
Comment 4 2017-06-21 05:58:50 PDT
Attachment 313508 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:841: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 5 2017-06-22 00:11:55 PDT
Created attachment 313590 [details] Patch I'm also keeping TestContextMenu and TestWebViewEditor as GTK+ only, I don't think we will be able to reuse those.
Build Bot
Comment 6 2017-06-22 00:14:44 PDT
Attachment 313590 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:841: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 7 2017-06-22 00:38:14 PDT
Created attachment 313592 [details] Patch for landing Fixed a typo in the makefile
Build Bot
Comment 8 2017-06-22 00:40:35 PDT
Attachment 313592 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:841: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 9 2017-06-22 00:48:09 PDT
Committed r218685: <http://trac.webkit.org/changeset/218685>
Note You need to log in before you can comment on or make changes to this bug.