Bug 173642 - [GTK] Move WebKit2 GLib API tests to glib directories
Summary: [GTK] Move WebKit2 GLib API tests to glib directories
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2017-06-21 03:23 PDT by Carlos Garcia Campos
Modified: 2017-06-22 00:48 PDT (History)
3 users (show)

See Also:

Attachments
Patch (46.74 KB, patch)
2017-06-21 03:27 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (45.98 KB, patch)
2017-06-21 05:56 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (45.14 KB, patch)
2017-06-22 00:11 PDT, Carlos Garcia Campos 		zan: review+
Details | Formatted Diff | Diff
Patch for landing (45.14 KB, patch)
2017-06-22 00:38 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-06-21 03:23:38 PDT 
So that they could be shared by WPE GLib API.
Comment 1 Carlos Garcia Campos 2017-06-21 03:27:23 PDT 
Created attachment 313503 [details]
Patch
Comment 2 Build Bot 2017-06-21 03:31:30 PDT 
Attachment 313503 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:841:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2017-06-21 05:56:07 PDT 
Created attachment 313508 [details]
Patch

Keep TestEditor as GTK+ only since it uses DOM API for everything.
Comment 4 Build Bot 2017-06-21 05:58:50 PDT 
Attachment 313508 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:841:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 48 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Carlos Garcia Campos 2017-06-22 00:11:55 PDT 
Created attachment 313590 [details]
Patch

I'm also keeping TestContextMenu and TestWebViewEditor as GTK+ only, I don't think we will be able to reuse those.
Comment 6 Build Bot 2017-06-22 00:14:44 PDT 
Attachment 313590 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:841:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Carlos Garcia Campos 2017-06-22 00:38:14 PDT 
Created attachment 313592 [details]
Patch for landing

Fixed a typo in the makefile
Comment 8 Build Bot 2017-06-22 00:40:35 PDT 
Attachment 313592 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:841:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Carlos Garcia Campos 2017-06-22 00:48:09 PDT 
Committed r218685: <http://trac.webkit.org/changeset/218685>