Bug 173638 - [MSVC] Fix compilation in CP932 (Shift_JIS) environment
Summary: [MSVC] Fix compilation in CP932 (Shift_JIS) environment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-20 21:52 PDT by Yoshiaki Jitsukawa
Modified: 2017-06-21 10:05 PDT (History)
5 users (show)

See Also:

Attachments
patch (1.25 KB, patch)
2017-06-20 22:11 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Jitsukawa 2017-06-20 21:52:32 PDT 
The following sources are encoded in UTF-8 (not ASCII) and cause compilation errors in CP932 (aka Shift_JIS, the default code page of Japanese version Windows).
Source\WebCore\platform\LocalizedStrings.cpp
Tools\TestWebKitAPI\Tests\WTF\StringImpl.cpp
Tools\TestWebKitAPI\Tests\WTF\StringView.cpp

Since MSVC's compiler doesn't do encoding detection, we should explicitly specify the encoding.
Comment 1 Yoshiaki Jitsukawa 2017-06-20 22:11:24 PDT 
Created attachment 313492 [details]
patch
Comment 2 WebKit Commit Bot 2017-06-21 10:05:32 PDT 
Comment on attachment 313492 [details]
patch

Clearing flags on attachment: 313492

Committed r218638: <http://trac.webkit.org/changeset/218638>
Comment 3 WebKit Commit Bot 2017-06-21 10:05:33 PDT 
All reviewed patches have been landed.  Closing bug.