WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
173638
[MSVC] Fix compilation in CP932 (Shift_JIS) environment
https://bugs.webkit.org/show_bug.cgi?id=173638
Summary
[MSVC] Fix compilation in CP932 (Shift_JIS) environment
Yoshiaki Jitsukawa
Reported
2017-06-20 21:52:32 PDT
The following sources are encoded in UTF-8 (not ASCII) and cause compilation errors in CP932 (aka Shift_JIS, the default code page of Japanese version Windows). Source\WebCore\platform\LocalizedStrings.cpp Tools\TestWebKitAPI\Tests\WTF\StringImpl.cpp Tools\TestWebKitAPI\Tests\WTF\StringView.cpp Since MSVC's compiler doesn't do encoding detection, we should explicitly specify the encoding.
Attachments
patch
(1.25 KB, patch)
2017-06-20 22:11 PDT
,
Yoshiaki Jitsukawa
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1
2017-06-20 22:11:24 PDT
Created
attachment 313492
[details]
patch
WebKit Commit Bot
Comment 2
2017-06-21 10:05:32 PDT
Comment on
attachment 313492
[details]
patch Clearing flags on attachment: 313492 Committed
r218638
: <
http://trac.webkit.org/changeset/218638
>
WebKit Commit Bot
Comment 3
2017-06-21 10:05:33 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug