Bug 173636 – [iOS DnD] [WK2] Add drag-and-drop release logging around WKContentView

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Wenson Hsieh]

Adding RELEASE_LOGs to key points in the drag-and-drop lifecycle will make sysdiagnoses actually contain useful information for debugging.

[Wenson Hsieh]

Created attachment 313484 [details]
Patch

[Wenson Hsieh]

Created attachment 313493 [details]
Add logging in one more spot.

[Tim Horton]

Comment on attachment 313493 [details]
Add logging in one more spot.

View in context: https://bugs.webkit.org/attachment.cgi?id=313493&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4518
> +            RELEASE_LOG(DragAndDrop, "Drag session failed: %p (no draggable content at %s)", session, NSStringFromCGPoint(dragOrigin).UTF8String);

Building an NSString just to print things? Why not just print the components?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4531
> +        RELEASE_LOG(DragAndDrop, "Drag session requested: %p at element bounds: %s", session, NSStringFromCGRect(state.elementBounds).UTF8String);

And again

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4721
> +        RELEASE_LOG(DragAndDrop, "Loaded data at %tu files", fileURLs.count);

*at*?

[Wenson Hsieh]

Comment on attachment 313493 [details]
Add logging in one more spot.

View in context: https://bugs.webkit.org/attachment.cgi?id=313493&action=review

Thanks!

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4518
>> +            RELEASE_LOG(DragAndDrop, "Drag session failed: %p (no draggable content at %s)", session, NSStringFromCGPoint(dragOrigin).UTF8String);
> 
> Building an NSString just to print things? Why not just print the components?

Sounds good -- I'll log the CGPoint x/y directly.

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4531
>> +        RELEASE_LOG(DragAndDrop, "Drag session requested: %p at element bounds: %s", session, NSStringFromCGRect(state.elementBounds).UTF8String);
> 
> And again

👍

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4721
>> +        RELEASE_LOG(DragAndDrop, "Loaded data at %tu files", fileURLs.count);
> 
> *at*?

I suppose "into" would be more fitting here -- fixed.

[Wenson Hsieh]

Created attachment 313534 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 313534 [details]
Patch for landing

Clearing flags on attachment: 313534

Committed r218642: <http://trac.webkit.org/changeset/218642>