Bug 173631 - Add support for structured serialization of CSS Geometry types
Summary: Add support for structured serialization of CSS Geometry types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL: https://drafts.fxtf.org/geometry-1/#s...
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-20 17:54 PDT by Sam Weinig
Modified: 2017-06-21 13:06 PDT (History)
3 users (show)

See Also:


Attachments
Patch (22.43 KB, patch)
2017-06-20 17:57 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (25.39 KB, patch)
2017-06-20 19:51 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (25.28 KB, patch)
2017-06-20 21:03 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-06-20 17:54:14 PDT
Add support for structured serialization of CSS Geometry types
Comment 1 Sam Weinig 2017-06-20 17:57:50 PDT
Created attachment 313462 [details]
Patch
Comment 2 Build Bot 2017-06-20 18:00:27 PDT
Attachment 313462 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:2471:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2017-06-20 19:51:25 PDT
Created attachment 313475 [details]
Patch
Comment 4 Build Bot 2017-06-20 19:53:20 PDT
Attachment 313475 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:2504:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Sam Weinig 2017-06-20 21:03:01 PDT
Created attachment 313483 [details]
Patch
Comment 6 Build Bot 2017-06-20 21:04:41 PDT
Attachment 313483 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:2504:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2017-06-21 13:06:03 PDT
Comment on attachment 313483 [details]
Patch

Clearing flags on attachment: 313483

Committed r218644: <http://trac.webkit.org/changeset/218644>
Comment 8 WebKit Commit Bot 2017-06-21 13:06:04 PDT
All reviewed patches have been landed.  Closing bug.