Bug 173626 - Add logging to identify when the Page suspends scripted animations
Summary: Add logging to identify when the Page suspends scripted animations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-20 17:00 PDT by Antoine Quint
Modified: 2017-06-21 11:37 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.31 KB, patch)
2017-06-20 17:04 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (10.28 KB, patch)
2017-06-20 17:36 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (10.25 KB, patch)
2017-06-21 10:59 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-06-20 17:00:24 PDT 
Add logging to identify when the Page suspends scripted animations
Comment 1 Antoine Quint 2017-06-20 17:04:17 PDT 
Created attachment 313456 [details]
Patch
Comment 2 Tim Horton 2017-06-20 17:06:37 PDT 
Comment on attachment 313456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313456&action=review

> Source/WebCore/page/Settings.in:303
> +shouldLogScriptedAnimationControllerSuspensionChange initial=true

Maybe initial=false and turn it on in DRT instead?
Comment 3 Antoine Quint 2017-06-20 17:36:35 PDT 
Created attachment 313460 [details]
Patch
Comment 4 Tim Horton 2017-06-21 10:52:46 PDT 
Comment on attachment 313460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313460&action=review

> Source/WebKit/mac/WebView/WebPreferences.mm:674
> +        [NSNumber numberWithBool:NO], WebKitShouldLogScriptedAnimationControllerSuspensionChangePreferenceKey,

You have some objection to the modern @NO like the previous few lines?
Comment 5 Antoine Quint 2017-06-21 10:54:31 PDT 
(In reply to Tim Horton from comment #4)
> Comment on attachment 313460 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313460&action=review
> 
> > Source/WebKit/mac/WebView/WebPreferences.mm:674
> > +        [NSNumber numberWithBool:NO], WebKitShouldLogScriptedAnimationControllerSuspensionChangePreferenceKey,
> 
> You have some objection to the modern @NO like the previous few lines?

I do not, just needed a little schooling. Will fix in commit.
Comment 6 Antoine Quint 2017-06-21 10:59:16 PDT 
Created attachment 313532 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2017-06-21 11:37:06 PDT 
Comment on attachment 313532 [details]
Patch for landing

Clearing flags on attachment: 313532

Committed r218640: <http://trac.webkit.org/changeset/218640>
Comment 8 WebKit Commit Bot 2017-06-21 11:37:08 PDT 
All reviewed patches have been landed.  Closing bug.