Bug 173623 - WebAudioSourceProvider should be thread safe ref counted
Summary: WebAudioSourceProvider should be thread safe ref counted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-20 15:56 PDT by youenn fablet
Modified: 2017-06-20 20:05 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2017-06-20 15:58 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-06-20 15:56:03 PDT 
WebAudioSourceProvider should be thread safe ref counted since it can be refer from main thread and audio thread.
Comment 1 youenn fablet 2017-06-20 15:58:25 PDT 
Created attachment 313449 [details]
Patch
Comment 2 youenn fablet 2017-06-20 16:06:35 PDT 
This change is needed since we are now calling prepare from the audio thread but we apparently want to call m_client->setFormat from the main thread.
Maybe we could make setFormat be ok when called from the audio thread if we would like to stick with RefCounted<>. It seems safer to go with ThreadSafeRefCounted for now.
Comment 3 WebKit Commit Bot 2017-06-20 20:05:42 PDT 
Comment on attachment 313449 [details]
Patch

Clearing flags on attachment: 313449

Committed r218622: <http://trac.webkit.org/changeset/218622>
Comment 4 WebKit Commit Bot 2017-06-20 20:05:43 PDT 
All reviewed patches have been landed.  Closing bug.