Bug 173605 - Pass the argument of DrawingArea::shouldUseTiledBackingForFrameView by reference
Summary: Pass the argument of DrawingArea::shouldUseTiledBackingForFrameView by reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on:
Blocks: 173644
  Show dependency tree / graph
 
Reported: 2017-06-20 09:55 PDT by Frédéric Wang (:fredw)
Modified: 2017-06-21 04:36 PDT (History)
1 user (show)

See Also:

Attachments
Patch (6.79 KB, patch)
2017-06-20 10:05 PDT, Frédéric Wang (:fredw) 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2017-06-20 09:55:35 PDT 
This function is only called from WebChromeClient::shouldUseTiledBackingForFrameView where the frame view is already available as a reference, so we don't really need to convert it to a pointer. This will avoid to do nullchecks in the derived classes.
Comment 1 Frédéric Wang (:fredw) 2017-06-20 10:05:38 PDT 
Created attachment 313410 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2017-06-20 23:24:59 PDT 
Committed r218625: <http://trac.webkit.org/changeset/218625>