Bug 173586 - Web Inspector: change the selected ScopeBarItem on mousedown instead of click
Summary: Web Inspector: change the selected ScopeBarItem on mousedown instead of click
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-19 22:27 PDT by Devin Rousso
Modified: 2017-06-20 20:13 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.74 KB, patch)
2017-06-19 22:31 PDT, Devin Rousso 		mattbaker: review+
Details | Formatted Diff | Diff
Patch (3.76 KB, patch)
2017-06-20 19:34 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-06-19 22:27:27 PDT 
This is currently done in the Elements tab sidebar, and it makes switching between sidebars/filers much faster.
Comment 1 Devin Rousso 2017-06-19 22:31:00 PDT 
Created attachment 313368 [details]
Patch
Comment 2 Nikita Vasilyev 2017-06-20 14:35:45 PDT 
Switching tabs is also on mousedown; this change makes it more consistent.
Comment 3 Matt Baker 2017-06-20 14:40:31 PDT 
Comment on attachment 313368 [details]
Patch

r=me. Please add a comment to the change log explaining the motivation for the change. I would mention consistency with the tab bar, etc.
Comment 4 Devin Rousso 2017-06-20 19:34:00 PDT 
Created attachment 313471 [details]
Patch
Comment 5 WebKit Commit Bot 2017-06-20 20:13:21 PDT 
Comment on attachment 313471 [details]
Patch

Clearing flags on attachment: 313471

Committed r218623: <http://trac.webkit.org/changeset/218623>
Comment 6 WebKit Commit Bot 2017-06-20 20:13:23 PDT 
All reviewed patches have been landed.  Closing bug.