Bug 173582 – [WTF] Rebaseline std::optional

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[WTF] Rebaseline std::optional

[Yusuke Suzuki]

Created attachment 313363 [details]
Patch

[Build Bot]

Attachment 313363 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Optional.h:539:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WTF/wtf/Optional.h:653:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WTF/wtf/Optional.h:654:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WTF/wtf/Optional.h:752:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WTF/wtf/Optional.h:754:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WTF/wtf/Optional.h:762:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WTF/wtf/Optional.h:763:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[JF Bastien]

Comment on attachment 313363 [details]
Patch

r=me

[Yusuke Suzuki]

Comment on attachment 313363 [details]
Patch

Thanks!

[WebKit Commit Bot]

Comment on attachment 313363 [details]
Patch

Clearing flags on attachment: 313363

Committed r218557: <http://trac.webkit.org/changeset/218557>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

So it's 2017, why do we still need our own std::optional? Is it for GCC 4.9?

[Yusuke Suzuki]

(In reply to Michael Catanzaro from comment #7)
> So it's 2017, why do we still need our own std::optional? Is it for GCC 4.9?

We are now using C++14, which does not include std::optional.
I think we can start discussion about upgrading this baseline.
But, at that time, we need to rely on newer GCC.

I think the current GCC baseline in WebKit is 4.9. Can we upgrade this?
If we can do that, we can start considering adopting C++17!

[Yusuke Suzuki]

(In reply to Yusuke Suzuki from comment #8)
> (In reply to Michael Catanzaro from comment #7)
> > So it's 2017, why do we still need our own std::optional? Is it for GCC 4.9?
> 
> We are now using C++14, which does not include std::optional.
> I think we can start discussion about upgrading this baseline.
> But, at that time, we need to rely on newer GCC.
> 
> I think the current GCC baseline in WebKit is 4.9. Can we upgrade this?
> If we can do that, we can start considering adopting C++17!

But, at that time, we also need to care about MSVC too.

[JF Bastien]

(In reply to Yusuke Suzuki from comment #9)
> (In reply to Yusuke Suzuki from comment #8)
> > (In reply to Michael Catanzaro from comment #7)
> > > So it's 2017, why do we still need our own std::optional? Is it for GCC 4.9?
> > 
> > We are now using C++14, which does not include std::optional.
> > I think we can start discussion about upgrading this baseline.
> > But, at that time, we need to rely on newer GCC.
> > 
> > I think the current GCC baseline in WebKit is 4.9. Can we upgrade this?
> > If we can do that, we can start considering adopting C++17!
> 
> But, at that time, we also need to care about MSVC too.

Recent MSVCs are really good at being up to date. I know their PM and engineers as well, they're very happy to fix shortcomings (but that takes a while to get back to our toolchains!).

I was going to propose we adopt a subset of C++17 after it's been ratified at the next meeting, which is at the start of July. Of course we need to make sure that subset is available in all compilers! e.g. the parallel STL isn't available anywhere.

[Yusuke Suzuki]

(In reply to JF Bastien from comment #10)
> (In reply to Yusuke Suzuki from comment #9)
> > (In reply to Yusuke Suzuki from comment #8)
> > > (In reply to Michael Catanzaro from comment #7)
> > > > So it's 2017, why do we still need our own std::optional? Is it for GCC 4.9?
> > > 
> > > We are now using C++14, which does not include std::optional.
> > > I think we can start discussion about upgrading this baseline.
> > > But, at that time, we need to rely on newer GCC.
> > > 
> > > I think the current GCC baseline in WebKit is 4.9. Can we upgrade this?
> > > If we can do that, we can start considering adopting C++17!
> > 
> > But, at that time, we also need to care about MSVC too.
> 
> Recent MSVCs are really good at being up to date. I know their PM and
> engineers as well, they're very happy to fix shortcomings (but that takes a
> while to get back to our toolchains!).

That sounds super nice!

> 
> I was going to propose we adopt a subset of C++17 after it's been ratified
> at the next meeting, which is at the start of July. Of course we need to
> make sure that subset is available in all compilers! e.g. the parallel STL
> isn't available anywhere.

It is very nice. After that, I think we can start updating GCC version.
Posted. https://lists.webkit.org/pipermail/webkit-dev/2017-June/029220.html