Bug 173570 – Occasional deadlocks under ensurePositionInformationIsUpToDate (incoming sync message with waitForAndDispatchImmediately)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Occasional deadlocks under ensurePositionInformationIsUpToDate (incoming sync message with waitForAndDispatchImmediately)

[Tim Horton]

Created attachment 313344 [details]
Patch

[Tim Horton]

rdar://problem/32720928

[Build Bot]

Attachment 313344 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:579:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:579:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:580:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:580:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:587:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:580:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:580:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:587:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
Total errors found: 8 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Wenson Hsieh]

Comment on attachment 313344 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313344&action=review

> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:127
> +    if (auto positionInformation = [delegate positionInformationForActionSheetAssistant:self])

Can this just be _positionInformation = [delegate positionInformationForActionSheetAssistant:self]?

> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:348
> +    [self synchronouslyRetrievePositionInformation];

Nit - I think it would be cleaner if this returned a BOOL like -ensurePositionInformationIsUpToDate:, so we could do something like

if (![self synchronouslyRetrievePositionInformation])
    return;

...etc...

> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:513
> +    [self synchronouslyRetrievePositionInformation];

Ditto.

> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:557
> +    [self synchronouslyRetrievePositionInformation];

Ditto.

[Wenson Hsieh]

Comment on attachment 313344 [details]
Patch

r=me

Please make sure that the PositionInformationTests still all pass.

[Tim Horton]

Tests all pass.

[Tim Horton]

https://trac.webkit.org/changeset/218606/webkit