Suppress Clang warnings in ANGLESupport
Created attachment 313320 [details] Patch
Comment on attachment 313320 [details] Patch What file causes this warning to trigger? Maybe we should just fix the code instead.
OutputHLSL.h, if all OutputHLSL::visit methods are marked with override, warnings are gone. I was reluctant to change it because it's 3rd-party code.
Comment on attachment 313320 [details] Patch Let's fix it and complain to https://github.com/google/angle if it's still in the upstream code.
Created attachment 313401 [details] Patch
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment on attachment 313401 [details] Patch Attachment 313401 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3967322 New failing tests: inspector/canvas/create-canvas-contexts.html
Created attachment 313422 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Also need to at least update changes.diff. (And, ideally, link to an upstream bug.)
(In reply to Michael Catanzaro from comment #9) > Also need to at least update changes.diff. (And, ideally, link to an > upstream bug.) Oops, should I not have done review+ without that? Nobody did review- so I thought it was OK.
Comment on attachment 313401 [details] Patch I trust Konstantin to update the .diff before landing, but until then cq-