NEW 173558
Add missing override specifiers to ANGLE 
https://bugs.webkit.org/show_bug.cgi?id=173558
Summary Add missing override specifiers to ANGLE
Konstantin Tokarev
Reported 2017-06-19 11:44:23 PDT
Suppress Clang warnings in ANGLESupport
Attachments
Patch (1.31 KB, patch)
2017-06-19 11:45 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (3.24 KB, patch)
2017-06-20 09:00 PDT, Konstantin Tokarev 		darin: review+
mcatanzaro: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-elcapitan (1.09 MB, application/zip)
2017-06-20 12:44 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2017-06-19 11:45:21 PDT
Created attachment 313320 [details] Patch
Alex Christensen
Comment 2 2017-06-19 12:46:43 PDT
Comment on attachment 313320 [details] Patch What file causes this warning to trigger? Maybe we should just fix the code instead.
Konstantin Tokarev
Comment 3 2017-06-19 12:55:32 PDT
OutputHLSL.h, if all OutputHLSL::visit methods are marked with override, warnings are gone. I was reluctant to change it because it's 3rd-party code.
Alex Christensen
Comment 4 2017-06-19 12:56:45 PDT
Comment on attachment 313320 [details] Patch Let's fix it and complain to https://github.com/google/angle if it's still in the upstream code.
Konstantin Tokarev
Comment 5 2017-06-20 09:00:52 PDT
Created attachment 313401 [details] Patch
Build Bot
Comment 6 2017-06-20 09:03:14 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Build Bot
Comment 7 2017-06-20 12:44:08 PDT
Comment on attachment 313401 [details] Patch Attachment 313401 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3967322 New failing tests: inspector/canvas/create-canvas-contexts.html
Build Bot
Comment 8 2017-06-20 12:44:09 PDT
Created attachment 313422 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Michael Catanzaro
Comment 9 2017-06-23 17:48:15 PDT
Also need to at least update changes.diff. (And, ideally, link to an upstream bug.)
Darin Adler
Comment 10 2017-06-25 20:42:58 PDT
(In reply to Michael Catanzaro from comment #9) > Also need to at least update changes.diff. (And, ideally, link to an > upstream bug.) Oops, should I not have done review+ without that? Nobody did review- so I thought it was OK.
Michael Catanzaro
Comment 11 2017-06-25 21:07:11 PDT
Comment on attachment 313401 [details] Patch I trust Konstantin to update the .diff before landing, but until then cq-
Note You need to log in before you can comment on or make changes to this bug.