The CurlDownload implementation includes CurlDownloadManager as a companion class for multiple download management. The class can be used from resource handle, so it should be separated from CurlDownload and to be prepare for further usage.
Created attachment 313335 [details]
Attachment 313335 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:86: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] 
ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] 
Total errors found: 2 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org
I didn't fix this style error because I've just change the header list on that file.
Created attachment 313408 [details]
Remove duplicated ChangeLog
Borrowed copyright from sibling source file
Remove unused interface.
Comment on attachment 313408 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=313408&action=review
> + CURLSH* curlsh = CurlManager::shared().getCurlShareHandle();
We usually use "singleton" in WebKit instead of "shared"
Created attachment 313524 [details]
(In reply to Alex Christensen from comment #8)
FYI, it broke the WinCairo build:
Oh, thank you. I am fixing this problem.
Created attachment 313653 [details]
Fix build error
This fix is to solve WinCairo build error.
The previous patch broke the wincairo build.
Comment on attachment 313653 [details]
Fix build error
rs=me, but it would be good to describe how this solves the issue in the ChangeLog.
I guess curl.h is smarter about checking if SOCKET is defined already? To avoid the redefinition error:
C:\Program Files (x86)\Windows Kits\8.1\include\um\winsock2.h(111): error C2371: 'SOCKET': redefinition; different basic types
I thought so and I can see the ifdef check inside curl/curl.h, but cannot solve this moment. I will keep refactoring this part and will see what's going on by following patches. I am so sorry about breaking the WinCairo build at this moment, so I hope this patch will be landed quickly.
If this fixes the build, we need the build fixed. We can't just have the build broken for many days at a time just because we're thinking about why a build fix works. If we need to improve it in the future, we will.