Bug 173547 - [GCrypt] Drop the AES-CFB support
Summary: [GCrypt] Drop the AES-CFB support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 133122
  Show dependency treegraph
 
Reported: 2017-06-19 07:00 PDT by Zan Dobersek
Modified: 2017-06-23 05:03 PDT (History)
3 users (show)

See Also:


Attachments
Patch (26.25 KB, patch)
2017-06-19 07:06 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1.02 MB, application/zip)
2017-06-19 08:13 PDT, Build Bot
no flags Details
Patch (26.45 KB, patch)
2017-06-19 08:24 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (26.46 KB, patch)
2017-06-19 08:57 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-06-19 07:00:42 PDT
[GCrypt] Drop the AES-CFB support
Comment 1 Zan Dobersek 2017-06-19 07:06:03 PDT
Created attachment 313291 [details]
Patch
Comment 2 Build Bot 2017-06-19 08:13:16 PDT
Comment on attachment 313291 [details]
Patch

Attachment 313291 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3957659

New failing tests:
fast/forms/file/intrinsic-min-width-overrides-width.html
Comment 3 Build Bot 2017-06-19 08:13:17 PDT
Created attachment 313297 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 4 Zan Dobersek 2017-06-19 08:24:26 PDT
Created attachment 313301 [details]
Patch
Comment 5 Zan Dobersek 2017-06-19 08:57:09 PDT
Created attachment 313304 [details]
Patch
Comment 6 Zan Dobersek 2017-06-19 08:57:18 PDT
For what it's worth this hasn't been discussed yet, but given it's code removal it's simple to provide a starting patch.

The idea is that the libgcrypt-based implementation would not, at least initially, support algorithms outside of the Web Crypto specification.
Comment 7 Jiewen Tan 2017-06-21 17:45:49 PDT
Comment on attachment 313304 [details]
Patch

Looks good to me. r=me.
Comment 8 Zan Dobersek 2017-06-23 05:03:13 PDT
Comment on attachment 313304 [details]
Patch

Clearing flags on attachment: 313304

Committed r218744: <http://trac.webkit.org/changeset/218744>
Comment 9 Zan Dobersek 2017-06-23 05:03:17 PDT
All reviewed patches have been landed.  Closing bug.