Bug 173546 – [WPE] Add initial implementation of glib API

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Carlos Garcia Campos]

Make current API files under glib directories build in WPE, and add the minimum implementation to make it work.

[Carlos Garcia Campos]

Created attachment 313287 [details]
Patch

[Zan Dobersek]

Comment on attachment 313287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313287&action=review

> Source/WebKit2/UIProcess/API/glib/WebKitUIClient.cpp:167
> +        // FIXME: I guess this is actually the view size in WPE. We need more refactoring here.
> +        return { 800, 600 };

This should return a (0,0)x(0,0) rect for now. Also, this would be strange if it compiled, since you only specify the size to initialize a FloatRect.

[Carlos Garcia Campos]

(In reply to Zan Dobersek from comment #2)
> Comment on attachment 313287 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313287&action=review
> 
> > Source/WebKit2/UIProcess/API/glib/WebKitUIClient.cpp:167
> > +        // FIXME: I guess this is actually the view size in WPE. We need more refactoring here.
> > +        return { 800, 600 };
> 
> This should return a (0,0)x(0,0) rect for now. Also, this would be strange
> if it compiled, since you only specify the size to initialize a FloatRect.

I had { } and changed it right before submitting the patch to provide a useful value, but forgot it's not a size, but a rectangle :-P

[Carlos Garcia Campos]

Created attachment 313288 [details]
Patch

This should build fine now

[Build Bot]

Comment on attachment 313288 [details]
Patch

Attachment 313288 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3957544

New failing tests:
inspector/canvas/create-canvas-contexts.html

[Build Bot]

Created attachment 313295 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Zan Dobersek]

Comment on attachment 313288 [details]
Patch

OK, let's try this.

[Carlos Garcia Campos]

Committed r218553: <http://trac.webkit.org/changeset/218553>