Bug 173535 - Use WTF::Function instead of std::function in more places in WebCore/
Summary: Use WTF::Function instead of std::function in more places in WebCore/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-18 21:00 PDT by Chris Dumez
Modified: 2017-06-19 13:12 PDT (History)
8 users (show)

See Also:

Attachments
Patch (110.33 KB, patch)
2017-06-18 21:28 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.05 MB, application/zip)
2017-06-18 22:25 PDT, Build Bot 		no flags Details
Patch (111.42 KB, patch)
2017-06-19 11:16 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-18 21:00:25 PDT 
Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
Comment 1 Chris Dumez 2017-06-18 21:28:23 PDT 
Created attachment 313260 [details]
Patch
Comment 2 Build Bot 2017-06-18 21:31:23 PDT 
Attachment 313260 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSValue.cpp:104:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSFontFaceSrcValue.cpp:88:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSCrossfadeValue.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/FrameView.cpp:2565:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/FrameView.h:686:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:409:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:468:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSValue.h:125:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSFilterImageValue.h:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/contentextensions/CombinedURLFilters.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/loader/cache/MemoryCache.cpp:276:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/MediaPlayerPrivate.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/css/CSSValueList.cpp:139:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleSheetContents.h:91:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/DOMWindow.cpp:2180:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/DOMWindow.cpp:2305:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSCrossfadeValue.cpp:209:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSImageValue.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSFontFaceSrcValue.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/loader/archive/cf/LegacyWebArchive.h:63:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSImageValue.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleProperties.h:136:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleProperties.cpp:1150:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSImageSetValue.cpp:155:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSFilterImageValue.cpp:167:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSImageSetValue.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSValueList.h:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleSheetContents.cpp:438:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleSheetContents.cpp:483:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 29 in 76 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2017-06-18 22:25:57 PDT 
Comment on attachment 313260 [details]
Patch

Attachment 313260 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3955562

New failing tests:
inspector/canvas/create-canvas-contexts.html
Comment 4 Build Bot 2017-06-18 22:25:58 PDT 
Created attachment 313262 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Chris Dumez 2017-06-19 11:16:20 PDT 
Created attachment 313314 [details]
Patch
Comment 6 Build Bot 2017-06-19 11:18:33 PDT 
Attachment 313314 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSValue.cpp:104:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSFontFaceSrcValue.cpp:88:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSCrossfadeValue.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/contentextensions/CombinedURLFilters.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/page/FrameView.cpp:2565:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/FrameView.h:684:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:409:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:468:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSValue.h:125:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSFilterImageValue.h:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/loader/cache/MemoryCache.cpp:276:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/MediaPlayerPrivate.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/css/CSSValueList.cpp:139:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleSheetContents.h:91:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/DOMWindow.cpp:2180:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/DOMWindow.cpp:2305:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSCrossfadeValue.cpp:209:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSImageValue.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSFontFaceSrcValue.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/loader/archive/cf/LegacyWebArchive.h:63:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSImageValue.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleProperties.h:136:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleProperties.cpp:1150:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSImageSetValue.cpp:155:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSFilterImageValue.cpp:167:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSImageSetValue.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/CSSValueList.h:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleSheetContents.cpp:438:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/css/StyleSheetContents.cpp:483:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 29 in 77 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Antti Koivisto 2017-06-19 12:51:04 PDT 
Comment on attachment 313314 [details]
Patch

rs=me
Comment 8 Chris Dumez 2017-06-19 12:53:22 PDT 
Comment on attachment 313314 [details]
Patch

Clearing flags on attachment: 313314

Committed r218501: <http://trac.webkit.org/changeset/218501>
Comment 9 Chris Dumez 2017-06-19 12:53:24 PDT 
All reviewed patches have been landed.  Closing bug.