Bug 173534 - Use WTF::Function instead of std::function in WebCore/Modules
Summary: Use WTF::Function instead of std::function in WebCore/Modules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-18 19:24 PDT by Chris Dumez
Modified: 2017-06-19 10:44 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.41 KB, patch)
2017-06-18 19:25 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (12.84 KB, patch)
2017-06-18 21:33 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (12.88 KB, patch)
2017-06-19 09:22 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-18 19:24:49 PDT 
Use WTF::Function instead of std::function in WebCore/Modules to avoid copying.
Comment 1 Chris Dumez 2017-06-18 19:25:41 PDT 
Created attachment 313254 [details]
Patch
Comment 2 Chris Dumez 2017-06-18 21:33:01 PDT 
Created attachment 313261 [details]
Patch
Comment 3 WebKit Commit Bot 2017-06-19 08:57:09 PDT 
Comment on attachment 313261 [details]
Patch

Rejecting attachment 313261 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 313261, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
intPeerConnection.cpp
patching file Source/WebCore/Modules/mediastream/MediaStreamRegistry.cpp
patching file Source/WebCore/Modules/mediastream/MediaStreamRegistry.h
Hunk #1 FAILED at 28.
Hunk #2 succeeded at 57 (offset 1 line).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Modules/mediastream/MediaStreamRegistry.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3958020
Comment 4 Chris Dumez 2017-06-19 09:22:12 PDT 
Created attachment 313305 [details]
Patch
Comment 5 WebKit Commit Bot 2017-06-19 10:44:23 PDT 
Comment on attachment 313305 [details]
Patch

Clearing flags on attachment: 313305

Committed r218498: <http://trac.webkit.org/changeset/218498>
Comment 6 WebKit Commit Bot 2017-06-19 10:44:25 PDT 
All reviewed patches have been landed.  Closing bug.