Bug 173531 - [WTF] Include execinfo.h and dlfcn.h based on platform defines
Summary: [WTF] Include execinfo.h and dlfcn.h based on platform defines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-18 18:44 PDT by Yusuke Suzuki
Modified: 2017-06-19 19:59 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.26 KB, patch)
2017-06-18 18:45 PDT, Yusuke Suzuki 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-06-18 18:44:49 PDT 
[WTF] Include execinfo.h and dlfcn.h based on platform defines
Comment 1 Yusuke Suzuki 2017-06-18 18:45:52 PDT 
Created attachment 313252 [details]
Patch
Comment 2 Alex Christensen 2017-06-19 08:57:28 PDT 
Comment on attachment 313252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313252&action=review

> Source/WTF/wtf/StackTrace.cpp:33
>  #if HAVE(BACKTRACE_SYMBOLS) || HAVE(DLADDR)

Maybe it would be more clear if this didn't contain the other two.
Comment 3 Yusuke Suzuki 2017-06-19 19:52:24 PDT 
Comment on attachment 313252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313252&action=review

Thanks!

>> Source/WTF/wtf/StackTrace.cpp:33
>>  #if HAVE(BACKTRACE_SYMBOLS) || HAVE(DLADDR)
> 
> Maybe it would be more clear if this didn't contain the other two.

Fixed.
Comment 4 Yusuke Suzuki 2017-06-19 19:59:36 PDT 
Committed r218526: <http://trac.webkit.org/changeset/218526>