RESOLVED FIXED 173526
Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function 
https://bugs.webkit.org/show_bug.cgi?id=173526
Summary Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
Darin Adler
Reported 2017-06-18 13:28:04 PDT
Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
Attachments
Patch (43.51 KB, patch)
2017-06-18 13:33 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (42.32 KB, patch)
2017-06-18 13:39 PDT, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2017-06-18 13:33:57 PDT
Created attachment 313243 [details] Patch
Darin Adler
Comment 2 2017-06-18 13:34:41 PDT
Chris, I’ll merge this WTF::Function test with the reentrancy test you made, once you land your patch.
Darin Adler
Comment 3 2017-06-18 13:39:07 PDT
Created attachment 313244 [details] Patch
Sam Weinig
Comment 4 2017-06-18 15:20:52 PDT
Comment on attachment 313244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313244&action=review > Source/WTF/ChangeLog:8 > + * wtf/Ref.h: Changed operator= to not be inlined. Added swap functions. I think you mean inline in the definition. It is still inlined.
Darin Adler
Comment 5 2017-06-19 10:01:18 PDT
Committed r218496: <http://trac.webkit.org/changeset/218496>
Note You need to log in before you can comment on or make changes to this bug.