Bug 173526 - Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
Summary: Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-18 13:28 PDT by Darin Adler
Modified: 2017-06-19 10:01 PDT (History)
2 users (show)

See Also:


Attachments
Patch (43.51 KB, patch)
2017-06-18 13:33 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (42.32 KB, patch)
2017-06-18 13:39 PDT, Darin Adler
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2017-06-18 13:28:04 PDT
Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
Comment 1 Darin Adler 2017-06-18 13:33:57 PDT
Created attachment 313243 [details]
Patch
Comment 2 Darin Adler 2017-06-18 13:34:41 PDT
Chris, I’ll merge this WTF::Function test with the reentrancy test you made, once you land your patch.
Comment 3 Darin Adler 2017-06-18 13:39:07 PDT
Created attachment 313244 [details]
Patch
Comment 4 Sam Weinig 2017-06-18 15:20:52 PDT
Comment on attachment 313244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313244&action=review

> Source/WTF/ChangeLog:8
> +        * wtf/Ref.h: Changed operator= to not be inlined. Added swap functions.

I think you mean inline in the definition.  It is still inlined.
Comment 5 Darin Adler 2017-06-19 10:01:18 PDT
Committed r218496: <http://trac.webkit.org/changeset/218496>