Bug 173525 - Remove 'EditCommand::isEditCommandComposition'.
Summary: Remove 'EditCommand::isEditCommandComposition'.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-18 11:16 PDT by dewei_zhu
Modified: 2017-06-18 20:12 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.58 KB, patch)
2017-06-18 11:19 PDT, dewei_zhu
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.07 MB, application/zip)
2017-06-18 12:03 PDT, Build Bot
no flags Details
Patch for landing (1.58 KB, patch)
2017-06-18 19:35 PDT, dewei_zhu
no flags Details | Formatted Diff | Diff
Patch for landing (1.57 KB, patch)
2017-06-18 19:37 PDT, dewei_zhu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2017-06-18 11:16:09 PDT
Remove 'EditCommand::isCompositeEditCommand'.
Comment 1 dewei_zhu 2017-06-18 11:19:36 PDT
Created attachment 313231 [details]
Patch
Comment 2 dewei_zhu 2017-06-18 11:20:43 PDT
(In reply to dewei_zhu from comment #0)
> Remove 'EditCommand::isCompositeEditCommand'.
I'm removing 'isCompositeEditCommand' not 'isCompositeEditCommand'.
Comment 3 dewei_zhu 2017-06-18 11:22:32 PDT
Comment on attachment 313231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313231&action=review

> Source/WebCore/ChangeLog:10
> +            1. isEditCommandComposition is not longer a subclass of EditCommand.

This should be 'EditCommandComposition' instead of 'isEditCommandComposition
Comment 4 Wenson Hsieh 2017-06-18 11:23:56 PDT
Comment on attachment 313231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313231&action=review

rs=me

> Source/WebCore/ChangeLog:7
> +

You have an extra newline here
Comment 5 Build Bot 2017-06-18 12:03:05 PDT
Comment on attachment 313231 [details]
Patch

Attachment 313231 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3953436

New failing tests:
inspector/canvas/create-canvas-contexts.html
Comment 6 Build Bot 2017-06-18 12:03:07 PDT
Created attachment 313233 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 dewei_zhu 2017-06-18 19:35:40 PDT
Created attachment 313255 [details]
Patch for landing
Comment 8 dewei_zhu 2017-06-18 19:37:47 PDT
Created attachment 313258 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2017-06-18 20:12:18 PDT
Comment on attachment 313258 [details]
Patch for landing

Clearing flags on attachment: 313258

Committed r218467: <http://trac.webkit.org/changeset/218467>
Comment 10 WebKit Commit Bot 2017-06-18 20:12:20 PDT
All reviewed patches have been landed.  Closing bug.