RESOLVED FIXED 173525
Remove 'EditCommand::isEditCommandComposition'. 
https://bugs.webkit.org/show_bug.cgi?id=173525
Summary Remove 'EditCommand::isEditCommandComposition'.
dewei_zhu
Reported 2017-06-18 11:16:09 PDT
Remove 'EditCommand::isCompositeEditCommand'.
Attachments
Patch (1.58 KB, patch)
2017-06-18 11:19 PDT, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-elcapitan (1.07 MB, application/zip)
2017-06-18 12:03 PDT, Build Bot 		no flags
Details
Patch for landing (1.58 KB, patch)
2017-06-18 19:35 PDT, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.57 KB, patch)
2017-06-18 19:37 PDT, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2017-06-18 11:19:36 PDT
Created attachment 313231 [details] Patch
dewei_zhu
Comment 2 2017-06-18 11:20:43 PDT
(In reply to dewei_zhu from comment #0) > Remove 'EditCommand::isCompositeEditCommand'. I'm removing 'isCompositeEditCommand' not 'isCompositeEditCommand'.
dewei_zhu
Comment 3 2017-06-18 11:22:32 PDT
Comment on attachment 313231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313231&action=review > Source/WebCore/ChangeLog:10 > + 1. isEditCommandComposition is not longer a subclass of EditCommand. This should be 'EditCommandComposition' instead of 'isEditCommandComposition
Wenson Hsieh
Comment 4 2017-06-18 11:23:56 PDT
Comment on attachment 313231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313231&action=review rs=me > Source/WebCore/ChangeLog:7 > + You have an extra newline here
Build Bot
Comment 5 2017-06-18 12:03:05 PDT
Comment on attachment 313231 [details] Patch Attachment 313231 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3953436 New failing tests: inspector/canvas/create-canvas-contexts.html
Build Bot
Comment 6 2017-06-18 12:03:07 PDT
Created attachment 313233 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
dewei_zhu
Comment 7 2017-06-18 19:35:40 PDT
Created attachment 313255 [details] Patch for landing
dewei_zhu
Comment 8 2017-06-18 19:37:47 PDT
Created attachment 313258 [details] Patch for landing
WebKit Commit Bot
Comment 9 2017-06-18 20:12:18 PDT
Comment on attachment 313258 [details] Patch for landing Clearing flags on attachment: 313258 Committed r218467: <http://trac.webkit.org/changeset/218467>
WebKit Commit Bot
Comment 10 2017-06-18 20:12:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.