Bug 173521 - [WebIDL] Move Touch related bindings in Document to their own IDL file
Summary: [WebIDL] Move Touch related bindings in Document to their own IDL file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-17 21:38 PDT by Sam Weinig
Modified: 2017-06-19 20:25 PDT (History)
1 user (show)

See Also:

Attachments
Patch (21.55 KB, patch)
2017-06-17 21:44 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (21.56 KB, patch)
2017-06-18 10:38 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (21.80 KB, patch)
2017-06-18 13:17 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (21.80 KB, patch)
2017-06-18 14:48 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (21.82 KB, patch)
2017-06-18 15:02 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (21.84 KB, patch)
2017-06-18 15:19 PDT, Sam Weinig 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-06-17 21:38:01 PDT 
[WebIDL] Move Touch related bindings in Document to their own IDL file
Comment 1 Sam Weinig 2017-06-17 21:44:17 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2017-06-18 10:38:27 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2017-06-18 13:17:35 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2017-06-18 14:48:32 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2017-06-18 15:02:31 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2017-06-18 15:19:21 PDT 
Created attachment 313247 [details]
Patch
Comment 7 Alex Christensen 2017-06-19 09:00:55 PDT 
Comment on attachment 313247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313247&action=review

> Source/WebCore/dom/TouchList.h:61
> +        m_values.reserveInitialCapacity(touches.size());

Why not just WTFMove touches into m_values?
Comment 8 Sam Weinig 2017-06-19 14:26:44 PDT 
(In reply to Alex Christensen from comment #7)
> Comment on attachment 313247 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313247&action=review
> 
> > Source/WebCore/dom/TouchList.h:61
> > +        m_values.reserveInitialCapacity(touches.size());
> 
> Why not just WTFMove touches into m_values?

Can't move Vector<std::reference_wrapper<Touch>> into Vector<Ref<Touch>>.

Thanks for the review.
Comment 9 Sam Weinig 2017-06-19 20:25:47 PDT 
Committed r218529: <http://trac.webkit.org/changeset/218529>