173513 – [WebIDL] Properly model buffer source / typed arrays as their own IDL types

Bug 173513 - [WebIDL] Properly model buffer source / typed arrays as their own IDL types

Summary: [WebIDL] Properly model buffer source / typed arrays as their own IDL types

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Sam Weinig

URL:
Keywords:

Depends on:
Blocks:

Reported:	2017-06-17 10:52 PDT by Sam Weinig
Modified:	2017-06-19 09:47 PDT (History)
CC List:	11 users (show)

See Also:

Attachments
Patch (72.59 KB, patch) 2017-06-17 11:13 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.40 MB, application/zip) 2017-06-17 12:24 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.50 MB, application/zip) 2017-06-17 12:29 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (10.94 MB, application/zip) 2017-06-17 12:50 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (2.00 MB, application/zip) 2017-06-17 12:54 PDT, Build Bot	no flags	Details
Patch (1.92 MB, patch) 2017-06-17 13:05 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (1.92 MB, patch) 2017-06-17 14:03 PDT, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sam Weinig 2017-06-17 10:52:32 PDT

[WebIDL] Properly model buffer source / typed arrays as their own IDL types

Comment 1 Sam Weinig 2017-06-17 11:13:43 PDT Comment hidden (obsolete)

Created attachment 313202 [details]
Patch

Comment 2 Build Bot 2017-06-17 12:24:14 PDT Comment hidden (obsolete)

Comment on attachment 313202 [details]
Patch

Attachment 313202 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3948777

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https.html
inspector/canvas/create-canvas-contexts.html
crypto/subtle/hkdf-derive-bits-malformed-parametrs.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.worker.html
crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters.html
crypto/subtle/pbkdf2-derive-bits-malformed-parametrs.html

Comment 3 Build Bot 2017-06-17 12:24:15 PDT Comment hidden (obsolete)

Created attachment 313204 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 4 Build Bot 2017-06-17 12:29:26 PDT Comment hidden (obsolete)

Comment on attachment 313202 [details]
Patch

Attachment 313202 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3948785

New failing tests:
crypto/subtle/hkdf-derive-bits-malformed-parametrs.html
crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https.html
crypto/subtle/pbkdf2-derive-bits-malformed-parametrs.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.worker.html

Comment 5 Build Bot 2017-06-17 12:29:28 PDT Comment hidden (obsolete)

Created attachment 313205 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

Comment 6 Build Bot 2017-06-17 12:50:23 PDT Comment hidden (obsolete)

Comment on attachment 313202 [details]
Patch

Attachment 313202 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3948795

New failing tests:
crypto/subtle/hkdf-derive-bits-malformed-parametrs.html
crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.worker.html
crypto/subtle/pbkdf2-derive-bits-malformed-parametrs.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https.html

Comment 7 Build Bot 2017-06-17 12:50:24 PDT Comment hidden (obsolete)

Created attachment 313208 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

Comment 8 Build Bot 2017-06-17 12:54:31 PDT Comment hidden (obsolete)

Comment on attachment 313202 [details]
Patch

Attachment 313202 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3948791

New failing tests:
crypto/subtle/hkdf-derive-bits-malformed-parametrs.html
crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https.html
crypto/subtle/pbkdf2-derive-bits-malformed-parametrs.html

Comment 9 Build Bot 2017-06-17 12:54:33 PDT Comment hidden (obsolete)

Created attachment 313209 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 10 Sam Weinig 2017-06-17 13:05:51 PDT Comment hidden (obsolete)

Created attachment 313211 [details]
Patch

Comment 11 Build Bot 2017-06-17 13:10:23 PDT Comment hidden (obsolete)

Comment on attachment 313211 [details]
Patch

Attachment 313211 [details] did not pass bindings-ews (mac):
Output: http://webkit-queues.webkit.org/results/3949041

New failing tests:
(JS) JSTestObj.cpp

Comment 12 Sam Weinig 2017-06-17 14:03:37 PDT

Created attachment 313212 [details]
Patch

Comment 13 Sam Weinig 2017-06-17 14:39:45 PDT

Reviewers: Don't be put off by the size of the patch. The vast majority of that comes from one huge test that mechanically had a lot exception strings changed.

Comment 14 Alex Christensen 2017-06-19 09:14:02 PDT

Comment on attachment 313212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313212&action=review

> Source/WebCore/bindings/js/JSDOMConvertUnion.h:38
> +struct ConditionalReturner;

Interesting.  I feel like there might be a better way to do this.

Comment 15 WebKit Commit Bot 2017-06-19 09:47:18 PDT

Comment on attachment 313212 [details]
Patch

Clearing flags on attachment: 313212

Committed r218495: <http://trac.webkit.org/changeset/218495>

Comment 16 WebKit Commit Bot 2017-06-19 09:47:20 PDT

All reviewed patches have been landed.  Closing bug.