Bug 173513 – [WebIDL] Properly model buffer source / typed arrays as their own IDL types

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[WebIDL] Properly model buffer source / typed arrays as their own IDL types

[Sam Weinig]

Created attachment 313202 [details]
Patch

[Build Bot]

Comment on attachment 313202 [details]
Patch

Attachment 313202 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3948777

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https.html
inspector/canvas/create-canvas-contexts.html
crypto/subtle/hkdf-derive-bits-malformed-parametrs.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.worker.html
crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters.html
crypto/subtle/pbkdf2-derive-bits-malformed-parametrs.html

[Build Bot]

Created attachment 313204 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 313202 [details]
Patch

Attachment 313202 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3948785

New failing tests:
crypto/subtle/hkdf-derive-bits-malformed-parametrs.html
crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https.html
crypto/subtle/pbkdf2-derive-bits-malformed-parametrs.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.worker.html

[Build Bot]

Created attachment 313205 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 313202 [details]
Patch

Attachment 313202 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3948795

New failing tests:
crypto/subtle/hkdf-derive-bits-malformed-parametrs.html
crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.worker.html
crypto/subtle/pbkdf2-derive-bits-malformed-parametrs.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https.html

[Build Bot]

Created attachment 313208 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Build Bot]

Comment on attachment 313202 [details]
Patch

Attachment 313202 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3948791

New failing tests:
crypto/subtle/hkdf-derive-bits-malformed-parametrs.html
crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https.html
crypto/subtle/pbkdf2-derive-bits-malformed-parametrs.html

[Build Bot]

Created attachment 313209 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Sam Weinig]

Created attachment 313211 [details]
Patch

[Build Bot]

Comment on attachment 313211 [details]
Patch

Attachment 313211 [details] did not pass bindings-ews (mac):
Output: http://webkit-queues.webkit.org/results/3949041

New failing tests:
(JS) JSTestObj.cpp

[Sam Weinig]

Created attachment 313212 [details]
Patch

[Sam Weinig]

Reviewers: Don't be put off by the size of the patch. The vast majority of that comes from one huge test that mechanically had a lot exception strings changed.

[Alex Christensen]

Comment on attachment 313212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313212&action=review

> Source/WebCore/bindings/js/JSDOMConvertUnion.h:38
> +struct ConditionalReturner;

Interesting.  I feel like there might be a better way to do this.

[WebKit Commit Bot]

Comment on attachment 313212 [details]
Patch

Clearing flags on attachment: 313212

Committed r218495: <http://trac.webkit.org/changeset/218495>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.