Now that it is ensured that the render tree can't get to the page cache.
Created attachment 313183 [details] Patch
Comment on attachment 313183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313183&action=review > Source/WebCore/ChangeLog:3 > + Demote the "we have navigated away" check to an assertion. I don't see anything getting demoted in this patch?
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 313183 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=313183&action=review > > > Source/WebCore/ChangeLog:3 > > + Demote the "we have navigated away" check to an assertion. > > I don't see anything getting demoted in this patch? FrameView* frameView = frame()->document() == this ? frame()->view() : nullptr vs. assert() + view()
Comment on attachment 313183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313183&action=review >>> Source/WebCore/ChangeLog:3 >>> + Demote the "we have navigated away" check to an assertion. >> >> I don't see anything getting demoted in this patch? > > FrameView* frameView = frame()->document() == this ? frame()->view() : nullptr > vs. > assert() + view() Ah, that's a bit subtle.
(In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 313183 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=313183&action=review > > >>> Source/WebCore/ChangeLog:3 > >>> + Demote the "we have navigated away" check to an assertion. > >> > >> I don't see anything getting demoted in this patch? > > > > FrameView* frameView = frame()->document() == this ? frame()->view() : nullptr > > vs. > > assert() + view() > > Ah, that's a bit subtle. yea, but that's the expected behavior now.
Comment on attachment 313183 [details] Patch Attachment 313183 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3945982 New failing tests: inspector/canvas/create-canvas-contexts.html
Created attachment 313187 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
(In reply to Build Bot from comment #6) > Comment on attachment 313183 [details] > Patch > > Attachment 313183 [details] did not pass mac-ews (mac): > Output: http://webkit-queues.webkit.org/results/3945982 > > New failing tests: > inspector/canvas/create-canvas-contexts.html really???
Comment on attachment 313183 [details] Patch Clearing flags on attachment: 313183 Committed r218456: <http://trac.webkit.org/changeset/218456>
All reviewed patches have been landed. Closing bug.
Comment on attachment 313183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313183&action=review > Source/WebCore/dom/Document.cpp:2215 > + ASSERT(frame() && frame()->document() == this); Please don’t use && in assertions. If you write this as two separate assertions, and half of it failed, we will be able to tell which half.
(In reply to Darin Adler from comment #11) > Comment on attachment 313183 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=313183&action=review > > > Source/WebCore/dom/Document.cpp:2215 > > + ASSERT(frame() && frame()->document() == this); > > Please don’t use && in assertions. If you write this as two separate > assertions, and half of it failed, we will be able to tell which half. Oh, right! I usually keep in mind not to merge them. Not sure what happened here. :( Thanks!
Committed r218462: <http://trac.webkit.org/changeset/218462>