Bug 173507 – REGRESSION(Sierra): Meter element doesn't work in RTL

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ryosuke Niwa]

In macOS Sierra and High Sierra, meter element in RTL context is drawn as if it's in LTR context.

[Ryosuke Niwa]

<rdar://problem/32827803>

[Ryosuke Niwa]

Created attachment 313189 [details]
Fixes the bug

[Sam Weinig]

Comment on attachment 313189 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=313189&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:1079
> +    [cell setUserInterfaceLayoutDirection: style.isLeftToRightDirection() ? NSUserInterfaceLayoutDirectionLeftToRight : NSUserInterfaceLayoutDirectionRightToLeft];

Does this method exist on El Capitan?

[Alexey Proskuryakov]

Comment on attachment 313189 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=313189&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:1077
> +    // FIXME: Remove the call to setBaseWritingDirection once __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 is always true.

Can it be in an #ifdef?

[Ryosuke Niwa]

(In reply to Sam Weinig from comment #3)
> Comment on attachment 313189 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313189&action=review
> 
> > Source/WebCore/rendering/RenderThemeMac.mm:1079
> > +    [cell setUserInterfaceLayoutDirection: style.isLeftToRightDirection() ? NSUserInterfaceLayoutDirectionLeftToRight : NSUserInterfaceLayoutDirectionRightToLeft];
> 
> Does this method exist on El Capitan?

Yes. It has been supported OS X 10.8.

(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 313189 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313189&action=review
> 
> > Source/WebCore/rendering/RenderThemeMac.mm:1077
> > +    // FIXME: Remove the call to setBaseWritingDirection once __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 is always true.
> 
> Can it be in an #ifdef?

What kind of #ifdef are you suggesting?

[Ryosuke Niwa]

Oh, I guess we can just call setUserInterfaceLayoutDirection only when __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 and call setBaseWritingDirection otherwise.

Will do that before landing.

[Ryosuke Niwa]

Created attachment 313256 [details]
Patch for landing

[Ryosuke Niwa]

Comment on attachment 313256 [details]
Patch for landing

Wait for EWS

[WebKit Commit Bot]

Comment on attachment 313256 [details]
Patch for landing

Clearing flags on attachment: 313256

Committed r218468: <http://trac.webkit.org/changeset/218468>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.