In macOS Sierra and High Sierra, meter element in RTL context is drawn as if it's in LTR context.
<rdar://problem/32827803>
Created attachment 313189 [details] Fixes the bug
Comment on attachment 313189 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=313189&action=review > Source/WebCore/rendering/RenderThemeMac.mm:1079 > + [cell setUserInterfaceLayoutDirection: style.isLeftToRightDirection() ? NSUserInterfaceLayoutDirectionLeftToRight : NSUserInterfaceLayoutDirectionRightToLeft]; Does this method exist on El Capitan?
Comment on attachment 313189 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=313189&action=review > Source/WebCore/rendering/RenderThemeMac.mm:1077 > + // FIXME: Remove the call to setBaseWritingDirection once __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 is always true. Can it be in an #ifdef?
(In reply to Sam Weinig from comment #3) > Comment on attachment 313189 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=313189&action=review > > > Source/WebCore/rendering/RenderThemeMac.mm:1079 > > + [cell setUserInterfaceLayoutDirection: style.isLeftToRightDirection() ? NSUserInterfaceLayoutDirectionLeftToRight : NSUserInterfaceLayoutDirectionRightToLeft]; > > Does this method exist on El Capitan? Yes. It has been supported OS X 10.8. (In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 313189 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=313189&action=review > > > Source/WebCore/rendering/RenderThemeMac.mm:1077 > > + // FIXME: Remove the call to setBaseWritingDirection once __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 is always true. > > Can it be in an #ifdef? What kind of #ifdef are you suggesting?
Oh, I guess we can just call setUserInterfaceLayoutDirection only when __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 and call setBaseWritingDirection otherwise. Will do that before landing.
Created attachment 313256 [details] Patch for landing
Comment on attachment 313256 [details] Patch for landing Wait for EWS
Comment on attachment 313256 [details] Patch for landing Clearing flags on attachment: 313256 Committed r218468: <http://trac.webkit.org/changeset/218468>
All reviewed patches have been landed. Closing bug.