Bug 173491 - Interpreter methods for mapping between Opcode and OpcodeID need not be instance methods.
Summary: Interpreter methods for mapping between Opcode and OpcodeID need not be insta...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-16 13:08 PDT by Mark Lam
Modified: 2017-06-16 14:03 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch. (45.11 KB, patch)
2017-06-16 13:37 PDT, Mark Lam 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-06-16 13:08:42 PDT 
This gets rid of some unnecessary work to get the interpreter pointer.
Comment 1 Mark Lam 2017-06-16 13:37:20 PDT 
Created attachment 313122 [details]
proposed patch.
Comment 2 Build Bot 2017-06-16 13:38:59 PDT 
Attachment 313122 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:195:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Keith Miller 2017-06-16 13:45:33 PDT 
Comment on attachment 313122 [details]
proposed patch.

r=me.
Comment 4 Mark Lam 2017-06-16 14:03:16 PDT 
Thanks for the review.  Landed in r218412: <http://trac.webkit.org/r218412>.