Bug 173485 - DRT fails to reset page visibility between tests
Summary: DRT fails to reset page visibility between tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-16 11:31 PDT by Chris Dumez
Modified: 2017-06-16 13:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2017-06-16 11:36 PDT, Chris Dumez 		ap: review+
simon.fraser: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-16 11:31:13 PDT 
DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility(). Fix this to address flakiness.
Comment 1 Chris Dumez 2017-06-16 11:36:36 PDT 
Created attachment 313098 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-06-16 13:07:49 PDT 
Comment on attachment 313098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313098&action=review

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:1830
> +    if (gTestRunner)
> +        gTestRunner->resetPageVisibility();
> +
>      if (gTestRunner) {

Can't you just have the if (gTestRunner) once?
Comment 3 Chris Dumez 2017-06-16 13:09:28 PDT 
Committed r218406: <http://trac.webkit.org/changeset/218406>